Currently the stdout of bitcoinds in functional tests is written to a file in self.datadir of the node. It is only read/examined after the node is shut down. To aid debugging it should (also?) be passed to the logger for visibility and timestamps.
tests: bitcoind stdout and error should be passed to the logger #13519
issue MarcoFalke opened this issue on June 21, 2018-
MarcoFalke commented at 2:00 PM on June 21, 2018: member
- MarcoFalke added the label Brainstorming on Jun 21, 2018
- MarcoFalke added the label Tests on Jun 21, 2018
- MarcoFalke added the label good first issue on Jun 21, 2018
-
jnewbery commented at 5:45 PM on June 21, 2018: member
I don't understand the "visibility and timestamps" comment. combine_logs interleaves node logs with test framework logs. Is there some missing functionality that would make debugging easier?
-
MarcoFalke commented at 6:26 PM on June 21, 2018: member
Sometimes the node writes to stdout or stderr. Do we also write to the debug.log in every such instance?
If so this issue can be closed based on a misunderstanding of mine.
-
jnewbery commented at 7:06 PM on June 21, 2018: member
No, sorry - you're right. We don't include stderr or stdout. My misunderstanding.
-
MarcoFalke commented at 8:39 PM on June 21, 2018: member
One solution would likely be to create a InitLogger in the "ui_interface" and call it in InitError and InitWarning. Then connect it for both the headless bitcoind and the gui.
- fanquake deleted a comment on Aug 2, 2018
- fanquake deleted a comment on Aug 2, 2018
- music referenced this in commit 6fef259d02 on Aug 14, 2018
- music referenced this in commit f8d2c21a53 on Aug 14, 2018
-
music commented at 4:03 AM on August 15, 2018: none
What do you mean by "connect it" for the headless bitcoind and gui? (I've taken to trying to fix it, sorry if this question is a bit common sense, this is my first bug.)
- MarcoFalke removed the label good first issue on Apr 17, 2019
- MarcoFalke closed this on Apr 17, 2019
-
MarcoFalke commented at 9:12 PM on April 17, 2019: member
Just appending it in combine_logs is probably fine:
- [test] combine_logs: append node stderr and stdout if it exists #15841
- MarcoFalke referenced this in commit 86edb79e97 on May 1, 2019
- sidhujag referenced this in commit f8f61428e1 on May 1, 2019
- dzutto referenced this in commit 905d9e83e8 on Oct 12, 2021
- dzutto referenced this in commit a89fdacab2 on Oct 12, 2021
- dzutto referenced this in commit 0d58cdabb7 on Oct 12, 2021
- pravblockc referenced this in commit 63c294eb77 on Nov 18, 2021
- MarcoFalke locked this on Dec 16, 2021
