qt: Move BitcoinGUI initializers to class, fix initializer order warning #13528

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2018_06_bitcoingui_initializers changing 2 files +48 −92

laanwj commented at 1:21 PM on June 24, 2018: member
- C++11-ize the code (move initializers to class, change 0 to nullptr where appropriate)
- Make sure m_wallet_selector is initialized
- And fix the following warning:
  
  bitcoin/src/qt/bitcoingui.cpp:122:5: warning: field 'spinnerFrame' will be initialized after field 'm_wallet_selector_label' [-Wreorder] spinnerFrame(0),
laanwj added the label GUI on Jun 24, 2018
promag commented at 1:55 PM on June 24, 2018: member

Heh this was on my TODO list 😆

utACK 5f0303c.

in src/qt/bitcoingui.h:116 in 5f0303c7dc outdated

 137 | +    QAction *usedReceivingAddressesAction = nullptr;
 138 | +    QAction *signMessageAction = nullptr;
 139 | +    QAction *verifyMessageAction = nullptr;
 140 | +    QAction *aboutAction = nullptr;
 141 | +    QAction *receiveCoinsAction = nullptr;
 142 |      QAction *receiveCoinsMenuAction;

MarcoFalke commented at 7:21 PM on June 24, 2018:

Why is this no longer initialized?

laanwj commented at 2:46 PM on June 25, 2018:

Ouch, I think I forgot that one, thanks for checking carefully.

MarcoFalke commented at 7:23 PM on June 24, 2018: member

utACK 5f0303c7dcde859ad25a947e28873bab37e219a5 beside question.

Also, could run through clang-format-diff.py to adjust to the coding style. Feel free to ignore this nit.

qt: Move BitcoinGUI initializers to class, fix initializer order warning

- C++11-ize the code (move initializers to class, change 0 to `nullptr` where appropriate)
- Make sure `m_wallet_selector` is initialized
- And fix the following warning:

    bitcoin/src/qt/bitcoingui.cpp:122:5:warning: field 'spinnerFrame' will be initialized after field 'm_wallet_selector_label' [-Wreorder]
        spinnerFrame(0),

bb3de15ad8

laanwj force-pushed on Jun 25, 2018
laanwj commented at 2:58 PM on June 25, 2018: member

Ok, made sure that receiveCoinsMenuAction is initialized and ran it through clang-format-diff.
MarcoFalke commented at 5:12 PM on June 25, 2018: member

re-utACK bb3de15ad8deba7b8b9740d9737dfe5bccf4e0e4 Only change is to address the feedback.
MarcoFalke merged this on Jun 25, 2018
MarcoFalke closed this on Jun 25, 2018
MarcoFalke referenced this in commit b877c39477 on Jun 25, 2018
UdjinM6 referenced this in commit 57cf2a2700 on Jun 20, 2021
UdjinM6 referenced this in commit b7e7267dfc on Jun 24, 2021
UdjinM6 referenced this in commit 39840b021a on Jun 29, 2021
UdjinM6 referenced this in commit 3f4ce86b73 on Jun 29, 2021
UdjinM6 referenced this in commit 7888c902fd on Jul 2, 2021
UdjinM6 referenced this in commit 73e27d5b0f on Jul 4, 2021
UdjinM6 referenced this in commit 4473811a2e on Jul 6, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels