Log warning when deprecated network name ’tor’ is used #13532

pull ghost wants to merge 1 commits into bitcoin:master from changing 1 files +5 −1
  1. ghost commented at 8:36 pm on June 24, 2018: none

    As @laanwj mentioned here, using option onlynet=tor is deprecated.

    I think it would be good to give the user a depcreaction warning feedback, so users can switch to onlynet=onion so there is a perspective for removing the deprecated tor in the future to decrease confusion.

    Currently, users maybe just wonder that they can use a undocumented option, or they are not aware that they use a deprecated option.

    Alternatively for the log warning message, I think at least this deprecetaion should be documented in the source code in a comment for readers of the source code.

  2. Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor) 9f8c54b1b5
  3. fanquake added the label P2P on Jun 24, 2018
  4. laanwj commented at 3:44 pm on June 25, 2018: member
    utACK 9f8c54b1b5ddedddf47fc51c1fcb533321f6f89f
  5. sipa commented at 6:53 pm on June 25, 2018: member
    utACK 9f8c54b1b5ddedddf47fc51c1fcb533321f6f89f
  6. promag commented at 3:11 pm on June 26, 2018: member

    utACK 9f8c54b.

    Makes sense to s/NET_TOR/NET_ONION/?

  7. jb55 approved
  8. jb55 commented at 7:53 pm on June 26, 2018: member
    ACK 9f8c54b1b5ddedddf47fc51c1fcb533321f6f89f
  9. sipa commented at 11:39 pm on June 26, 2018: member
    utACK 9f8c54b1b5ddedddf47fc51c1fcb533321f6f89f
  10. laanwj merged this on Jun 27, 2018
  11. laanwj closed this on Jun 27, 2018

  12. laanwj referenced this in commit 7209fec190 on Jun 27, 2018
  13. unknown deleted the branch on Jun 30, 2018
  14. laanwj referenced this in commit 5c05dd6285 on Jul 4, 2018
  15. PastaPastaPasta referenced this in commit 33787241d5 on Apr 16, 2020
  16. PastaPastaPasta referenced this in commit 89815fa2c8 on Apr 16, 2020
  17. PastaPastaPasta referenced this in commit bb02ff1774 on Apr 19, 2020
  18. PastaPastaPasta referenced this in commit 1b6227ad3d on Apr 20, 2020
  19. PastaPastaPasta referenced this in commit 45aef679d0 on May 10, 2020
  20. PastaPastaPasta referenced this in commit 674ad86c32 on May 12, 2020
  21. PastaPastaPasta referenced this in commit 0f7f679c14 on Jun 9, 2020
  22. PastaPastaPasta referenced this in commit d0c2101736 on Jun 9, 2020
  23. PastaPastaPasta referenced this in commit c018c32753 on Jun 10, 2020
  24. PastaPastaPasta referenced this in commit 889e0bf276 on Jun 11, 2020
  25. gades referenced this in commit 6087f72d15 on Jun 25, 2021
  26. random-zebra referenced this in commit 85f000ecbe on Jul 30, 2021
  27. random-zebra referenced this in commit b4751e10ce on Aug 11, 2021
  28. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-08 22:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me