[qt] coincontrol: Remove unused qt4 workaround #13536

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1806-qtCoinNo4 changing 1 files +0 −4

MarcoFalke commented at 1:33 PM on June 25, 2018: member

This reverts 55eade9d46ebfa4b32b79893595d91d529fa30bb since it is no longer required.
[qt] coincontrol: Remove unused qt4 workaround faa2cf685a
MarcoFalke added the label GUI on Jun 25, 2018
MarcoFalke commented at 1:36 PM on June 25, 2018: member

original buggy screenshot for reference from #5716:

Coin Control's first column label is simply "1". What is that supposed to mean?

After my patch:
promag commented at 2:19 PM on June 25, 2018: member

utACK faa2cf68.

in src/qt/coincontroldialog.cpp:121 in faa2cf685a

 117 | @@ -118,10 +118,6 @@ CoinControlDialog::CoinControlDialog(const PlatformStyle *_platformStyle, QWidge
 118 |      // (un)select all
 119 |      connect(ui->pushButtonSelectAll, SIGNAL(clicked()), this, SLOT(buttonSelectAllClicked()));
 120 |  
 121 | -    // change coin control first column label due Qt4 bug.

laanwj commented at 3:45 PM on June 25, 2018:

Oh, this can be removed completely? I interpreted "first" as "otherwise it's needed later", that's why I didn't touch it.

laanwj commented at 3:46 PM on June 25, 2018: member

utACK faa2cf685a41279611eedf2f81255e412df8375b
MarcoFalke merged this on Jun 25, 2018
MarcoFalke closed this on Jun 25, 2018
MarcoFalke referenced this in commit baf3a3ab0c on Jun 25, 2018
MarcoFalke deleted the branch on Jun 25, 2018
jasonbcox referenced this in commit a3cc9379de on Sep 27, 2019
10xcryptodev referenced this in commit 75817f64dd on May 14, 2020
10xcryptodev referenced this in commit 0b3617f689 on May 15, 2020
10xcryptodev referenced this in commit 5d1c3e8a5f on May 20, 2020
10xcryptodev referenced this in commit 3870adcbdf on Jun 12, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels