[wallet] loadwallet shouldn’t create new wallets. #13564

1. 
   jnewbery commented at 5:37 pm on June 28, 2018: member

   A bug in the initial implementation of loadwallet meant that if the arguement was a directory that didn’t contain a wallet.dat file, a new wallet would be created in that directory. Fix that so that if a directory is passed in, it must contain a wallet.dat file.

   Bug reported by promag (João Barbosa).

2. [wallet] loadwallet shouldn't create new wallets.

   A bug in the initial implementation of loadwallet meant that if the
   arguement was a directory that didn't contain a wallet.dat file, a new
   wallet would be created in that directory. Fix that so that if a
   directory is passed in, it must contain a wallet.dat file.
   
   Bug reported by promag (João Barbosa).

   ea65182f03
3. jnewbery force-pushed on Jun 28, 2018
4. 
   jnewbery commented at 5:38 pm on June 28, 2018: member

   cc @promag
5. 
   promag commented at 6:07 pm on June 28, 2018: member

   Looks good, will test.
6. MarcoFalke added this to the milestone 0.17.0 on Jun 28, 2018
7. fanquake added the label Wallet on Jun 28, 2018
8. 
   promag commented at 0:51 am on June 29, 2018: member

   FYI I’ll have to move these checks to another place to reuse in the node interface (for the UI).

   Could also test an absolute path?

9. 
   promag commented at 9:34 am on June 30, 2018: member

   Tested ACK ea65182. Expected behaviour with local or external wallets. Also works if the directory is a symlink. Just 2 nits:

   • test an absolute path (external wallet);
   • error could be invalid wallet - I mean, could avoid wallet.dat detail.
10. 
    laanwj commented at 4:18 pm on July 5, 2018: member

    at some point we might want to put wallet.dat in some constant, instead of repeating the string everywhere. But not necessarily here. utACK ea65182f033eca73c291057dacd54f8e4e809fbd
11. 
    ken2812221 commented at 8:36 pm on July 5, 2018: contributor

    utACK ea65182f033eca73c291057dacd54f8e4e809fbd
12. MarcoFalke merged this on Jul 7, 2018
13. MarcoFalke closed this on Jul 7, 2018

    ---

14. MarcoFalke referenced this in commit 88a15ebc8d on Jul 7, 2018
15. 
    MarcoFalke commented at 5:10 pm on July 7, 2018: member

    utACK ea65182f03
16. jasonbcox referenced this in commit 9a4a353f13 on Oct 25, 2019
17. PastaPastaPasta referenced this in commit 84b1dccc87 on Jul 7, 2020
18. UdjinM6 referenced this in commit fafa767e57 on Jul 8, 2020
19. PastaPastaPasta referenced this in commit 6a249f59b6 on Aug 23, 2020
20. ckti referenced this in commit 98dafb0e2a on Mar 28, 2021
21. MarcoFalke locked this on Sep 8, 2021

Contributors
jnewbery promag laanwj ken2812221 MarcoFalke

Labels
Wallet

Milestone
0.17.0