Fix UpdateTip log error typo #13610

pull qshuai wants to merge 1 commits into bitcoin:master from qshuai:master changing 1 files +1 −1

qshuai commented at 3:00 PM on July 7, 2018: none

The following is correct: 2018-07-07 14:58:31 UpdateTip: new best=00000000000038230e39621092289313f5b7ec7f16e05a44a05ed5c670385936 height=631644 version=0x00000004 log2_work=66.837168 tx=8733448 date='2016-01-05 21:50:05' progress=0.437787 cache=6.8MiB(52427utxo)

Not: 2018-07-07 14:58:31 UpdateTip: new best=00000000000038230e39621092289313f5b7ec7f16e05a44a05ed5c670385936 height=631644 version=0x00000004 log2_work=66.837168 tx=8733448 date='2016-01-05 21:50:05' progress=0.437787 cache=6.8MiB(52427txo)
Fix UpdateTip log error typo 90375f7162

in src/validation.cpp:2292 in 90375f7162

2288 | @@ -2289,7 +2289,7 @@ void static UpdateTip(const CBlockIndex *pindexNew, const CChainParams& chainPar
2289 |              DoWarning(strWarning);
2290 |          }
2291 |      }
2292 | -    LogPrintf("%s: new best=%s height=%d version=0x%08x log2_work=%.8g tx=%lu date='%s' progress=%f cache=%.1fMiB(%utxo)", __func__, /* Continued */
2293 | +    LogPrintf("%s: new best=%s height=%d version=0x%08x log2_work=%.8g tx=%lu date='%s' progress=%f cache=%.1fMiB(%dutxo)", __func__, /* Continued */

promag commented at 9:44 PM on July 7, 2018:

It's unsigned int CCoinsViewCache::GetCacheSize() so it should be %uutxo.

sipa commented at 12:12 AM on July 8, 2018:

@promag That doesn't matter for LogPrintf.

promag commented at 9:19 PM on July 8, 2018:

Thanks! There are some %u in the code though.

sipa commented at 9:27 PM on July 8, 2018:

@promag Yes, doesn't matter. tinyformat doesn't care about the format specifier; it always converts values based on their data type.

sipa commented at 12:13 AM on July 8, 2018: member

@qshuai It is actually intended to be 'txo'. Cache entries can refer to spent or unspent transaction outputs.
qshuai commented at 3:27 AM on July 8, 2018: none

@sipa Oh, yes，it is!!!
qshuai closed this on Jul 8, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

qshuai

promag

sipa