GUI: move class HelpMessageBox to guiutil.cpp/.h #1364

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:move_HelpMessage_GUIUtil_add_RPCCon_Button changing 6 files +93 −54

Diapolo commented at 1:53 PM on May 20, 2012: none
- move class HelpMessageBox to guiutil.cpp/.h
- add button to show Bitcoin options (in RPC Console -> Information)
- resize Debug window a little to allow for a non-breaking display of the welcome message with non-english translation
- use 50 nonbreaking spaces (up from 40) on Windows to widen the HelpMessage Box for better readability
Diapolo commented at 12:26 PM on May 21, 2012: none

Rebased, fixing a merge conflict!
laanwj commented at 4:58 PM on May 21, 2012: member

Agree with moving HelpMessageBox to guiutil.h

I'm not sure about the "options" naming though. We already have an options dialog. This will generate confusion.
Diapolo commented at 5:07 PM on May 21, 2012: none

I guess we should call the "options" in that case parameters as that describes, what they are.
laanwj commented at 5:11 PM on May 21, 2012: member

Yes that's better
Diapolo commented at 5:35 PM on May 21, 2012: none

Okay, updated to use the word "parameters" in this case.
laanwj commented at 5:44 PM on May 21, 2012: member

Uhm, you don't have to change it everywhere throughout the program. Just for the button... no need to make core changes for an UI improvement.
Diapolo commented at 5:59 PM on May 21, 2012: none

I believe it would be a bad idea to show "options" AND "parameters" for the same thing ... it IS a rename, but it makes sens. Just write "Bitcoin paramaters" on a label and when you click show you read "options" ... how missleading is this :)?
laanwj commented at 6:04 PM on May 21, 2012: member

Well maybe call it "command-line options" then. It already makes it distinct from the UI options.
Diapolo commented at 6:21 PM on May 21, 2012: none

That's the best solution ... I need to revert some changes then ^^.
Diapolo commented at 8:46 PM on May 21, 2012: none

Updated and now just using "command-line options" in the label above the added button and instead "options" displayed in the header of the help message. No further changes were made.
move class HelpMessageBox to guiutil.cpp/.h / add button to show Bitcoin command-line options (in RPC Console -> Information) / resize Debug window a little to allow for a non-breaking display of the welcome message with non-english translation 5d6b30271f
Diapolo commented at 2:34 PM on June 1, 2012: none

Rebased and ready to merge.
laanwj referenced this in commit 1c85a7f3eb on Jun 2, 2012
laanwj merged this on Jun 2, 2012
laanwj closed this on Jun 2, 2012
coblee referenced this in commit 7e3d2fe392 on Jul 17, 2012
suprnurd referenced this in commit d63080100a on Dec 5, 2017
lateminer referenced this in commit 4d5ded5eaf on Jan 22, 2019
lateminer referenced this in commit f4339f4621 on May 6, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj