[tests] skip rpc_zmq functional test as necessary #13645

1. 
   jamesob commented at 3:54 PM on July 12, 2018: member

   As noted in https://github.com/bitcoin/bitcoin/pull/13570/files#r201715904, the rpc_zmq functional test should be skipped when the zmq python3 package is not installed. This is breaking https://bitcoinperf.com benchmarks at the moment.

2. in test/functional/rpc_zmq.py:21 in 49ea56689b outdated

     16 | @@ -17,6 +17,11 @@ def set_test_params(self):
     17 |          self.setup_clean_chain = True
     18 |  
     19 |      def run_test(self):
     20 | +        try:
     21 | +            import zmq
   

   ---

   ---

   

   MarcoFalke commented at 4:05 PM on July 12, 2018:

   I believe it should see if zmq is compiled into bitcoind (see the test config file)

3. MarcoFalke added this to the milestone 0.17.0 on Jul 12, 2018
4. 
   MarcoFalke commented at 4:06 PM on July 12, 2018: member

   Thanks, Concept ACK

5. MarcoFalke added the label Tests on Jul 12, 2018
6. 
   DrahtBot commented at 4:12 PM on July 12, 2018: member

   <!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:

   • #13646 (tests: Skip rpc_zmq.py when ZMQ is disabled by domob1812)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. jamesob force-pushed on Jul 12, 2018
8. 
   jamesob commented at 5:02 PM on July 12, 2018: member

   @MarcoFalke thanks for the look. I've pushed an updated version which addresses your feedback and does a minor cleanup.

9. jamesob force-pushed on Jul 12, 2018
10. jamesob force-pushed on Jul 12, 2018
11. [tests] skip rpc_zmq functional test when python3 zmq lib is not present

    Also refactors zmq-related test skipping logic into distinct functions.

    a0b604c166
12. jamesob force-pushed on Jul 12, 2018
13. 
    AtsukiTak commented at 6:06 AM on July 13, 2018: contributor

    ACK Tested in my macOS High Sierra 10.13 environment.

14. 
    promag commented at 7:06 AM on July 13, 2018: member

    I prefer this over #13646.

15. 
    MarcoFalke commented at 10:00 AM on July 13, 2018: member

    utACK a0b604c166

16. MarcoFalke merged this on Jul 13, 2018
17. MarcoFalke closed this on Jul 13, 2018

    ---

18. MarcoFalke referenced this in commit 2ea7eb62b2 on Jul 13, 2018
19. PastaPastaPasta referenced this in commit 15d6516c42 on Dec 16, 2020
20. xdustinface referenced this in commit bc8cf7494b on Dec 18, 2020
21. PastaPastaPasta referenced this in commit 8de07e66f5 on Dec 18, 2020
22. PastaPastaPasta referenced this in commit 93c5cae234 on Dec 18, 2020
23. PastaPastaPasta referenced this in commit c8b887cf99 on Dec 18, 2020
24. PastaPastaPasta referenced this in commit 0a255fec40 on Dec 18, 2020
25. PastaPastaPasta referenced this in commit 724e8aed19 on Dec 18, 2020
26. MarcoFalke locked this on Sep 8, 2021

Milestone
0.17.0