[travis] Don't store debug info if --enable-debug is set #13650

1. 
   ken2812221 commented at 8:25 PM on July 12, 2018: contributor

   After #12686 merged, ccache store huge size of .o files, simply get rid of those useless debug info.

   Fixes #13748

2. 
   ken2812221 commented at 8:25 PM on July 12, 2018: contributor

   ping @theuni

3. laanwj added the label Bug on Jul 12, 2018
4. laanwj added the label Tests on Jul 12, 2018
5. laanwj removed the label Bug on Jul 12, 2018
6. 
   laanwj commented at 8:32 PM on July 12, 2018: member

   Doesn't this override the flags completely, so also change optimization etc? (not that it probably matters)

7. 
   sipa commented at 9:32 PM on July 12, 2018: member

   From the Travis log:

   CXXFLAGS      =  -Og -g3 -ftrapv  -Wstack-protector -fstack-protector-all     -pipe -O1 -g0
   

   So it seems it isn't being overridden.

8. 
   laanwj commented at 9:51 PM on July 12, 2018: member

   That's weird. It even still passes in -g3. So I'd hope the last-passed option is effective?

9. 
   ken2812221 commented at 2:35 AM on July 13, 2018: contributor

   Yes, the latter option can override the previous one. Restarted that job, and you can se the effect.

10. laanwj requested review from theuni on Jul 13, 2018
11. 
    DrahtBot commented at 7:22 PM on July 13, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:

    • #12134 (Build previous releases and run functional tests by Sjors)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

12. [travis] Don't store debug info if --enable-debug is set 14788fbada
13. ken2812221 force-pushed on Jul 19, 2018
14. ken2812221 force-pushed on Jul 19, 2018
15. ken2812221 force-pushed on Jul 19, 2018
16. 
    MarcoFalke commented at 8:30 PM on July 23, 2018: member

    On travis the time is back to 10 minutes and the flags are appended

    https://travis-ci.org/bitcoin/bitcoin/jobs/405944009#L2388

    ACK from me

17. 
    MarcoFalke commented at 8:31 PM on July 23, 2018: member

    @theuni Any objections to merge 14788fb?

18. MarcoFalke merged this on Jul 24, 2018
19. MarcoFalke closed this on Jul 24, 2018

    ---

20. MarcoFalke referenced this in commit 7a9bca61fa on Jul 24, 2018
21. ken2812221 deleted the branch on Jul 25, 2018
22. DrahtBot locked this on Sep 8, 2021

Review Requested
theuni