wallet: Fix backupwallet for multiwallets #13667

1. 
   domob1812 commented at 9:20 am on July 15, 2018: contributor

   backupwallet was broken for multiwallets in their own directories (i.e. something like DATADIR/wallets/mywallet/wallet.dat). In this case, the backup would use DATADIR/wallets/wallet.dat as source file and not take the specific wallet’s directory into account.

   This led to either an error during the backup (if the wrong source file was not present) or would silently back up the wrong wallet; especially the latter behaviour can be quite bad for users.

2. fanquake added the label Wallet on Jul 15, 2018
3. wallet: Fix backupwallet for multiwallets

   backupwallet was broken for multiwallets in their own directories
   (i.e. something like DATADIR/wallets/mywallet/wallet.dat).  In this
   case, the backup would use DATADIR/wallets/wallet.dat as source file
   and not take the specific wallet's directory into account.
   
   This led to either an error during the backup (if the wrong source
   file was not present) or would silently back up the wrong wallet;
   especially the latter behaviour can be quite bad for users.

   a1a998cf24
4. domob1812 force-pushed on Jul 15, 2018
5. 
   MarcoFalke commented at 4:04 pm on July 15, 2018: member

   Would this require backport to the 0.16 branch?
6. 
   promag commented at 4:05 pm on July 15, 2018: member

   utACK a1a998c. No travis?
7. 
   domob1812 commented at 4:57 pm on July 15, 2018: contributor

   I think that 0.16 does not yet support multiwallets in their own subdirectories, does it? Then it would not require a backport.
8. 
   MarcoFalke commented at 9:27 pm on July 15, 2018: member

   Thanks, just wanted to ask for clarity.
9. domob1812 referenced this in commit 89951e00cf on Jul 16, 2018
10. 
    DrahtBot commented at 11:20 am on July 16, 2018: member
11. 
    domob1812 commented at 4:06 pm on August 5, 2018: contributor

    Is there anything I need to do here?
12. MarcoFalke added this to the milestone 0.17.0 on Aug 5, 2018
13. 
    laanwj commented at 11:31 am on August 7, 2018: member

    utACK a1a998cf24c0cf1232e44ec8eaf2ad6875ab5153
14. laanwj merged this on Aug 7, 2018
15. laanwj closed this on Aug 7, 2018

    ---

16. laanwj referenced this in commit b81a8a5ea9 on Aug 7, 2018
17. domob1812 deleted the branch on Aug 7, 2018
18. 
    Hary2511 commented at 5:22 pm on August 7, 2018: none

    What should I do here
19. jasonbcox referenced this in commit 903f7859b4 on Dec 20, 2019
20. jonspock referenced this in commit b58a0ad875 on Oct 2, 2020
21. jonspock referenced this in commit fa0b8eb8cb on Oct 5, 2020
22. jonspock referenced this in commit 0101347c8a on Oct 10, 2020
23. PastaPastaPasta referenced this in commit d8bdd210a1 on Feb 2, 2021
24. PastaPastaPasta referenced this in commit 58965e41ea on Feb 4, 2021
25. UdjinM6 referenced this in commit 10ec1200d9 on Jun 30, 2021
26. UdjinM6 referenced this in commit a77d944408 on Jul 1, 2021
27. UdjinM6 referenced this in commit 7a2a63ef34 on Jul 2, 2021
28. UdjinM6 referenced this in commit 0214211a7f on Jul 2, 2021
29. DrahtBot locked this on Sep 8, 2021

Contributors
domob1812 MarcoFalke promag DrahtBot laanwj Hary2511

Labels
Wallet

Milestone
0.17.0