travis: Check that ~/.bitcoin is never created #13687

1. 
   MarcoFalke commented at 12:12 pm on July 17, 2018: member
2. travis: Check that ~/.bitcoin is never created 41a8c8dfaf
3. MarcoFalke added the label Tests on Jul 17, 2018
4. MarcoFalke added the label Up for grabs on Jul 17, 2018
5. 
   laanwj commented at 12:28 pm on July 17, 2018: member

   Nice. For some reason I thought we already had this. Concept ACK.
6. 
   MarcoFalke commented at 12:34 pm on July 17, 2018: member

   Travis failure:

    0  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_config_args.py", line 39, in run_test
    1
    2    self.nodes[0].assert_start_raises_init_error(['-conf=' + conf_file], 'Error reading configuration file: specified data directory "' + new_data_dir + '" does not exist.')
    3
    4  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_node.py", line 266, in assert_start_raises_init_error
    5
    6    'Expected message "{}" does not fully match stderr:\n"{}"'.format(expected_msg, stderr))
    7
    8  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_node.py", line 108, in _raise_assertion_error
    9
   10    raise AssertionError(self._node_msg(msg))
   11
   12AssertionError: [node 0] Expected message "Error reading configuration file: specified data directory "/tmp/bitcoin_test_runner_20180717_122100/feature_config_args_1/node0/newdatadir" does not exist." does not fully match stderr:
   13
   14"************************
   15
   16EXCEPTION: N5boost10filesystem16filesystem_errorE       
   17
   18boost::filesystem::create_directory: File exists: "/root/.bitcoin"       
   19
   20bitcoin in AppInit()
   

7. 
   MarcoFalke commented at 12:35 pm on July 17, 2018: member

   I have no idea how to fix the broken functional test cross platform without removing it.

   Closing as “up for grabs”.

8. MarcoFalke closed this on Jul 17, 2018

   ---

9. MarcoFalke deleted the branch on Jul 17, 2018
10. 
    laanwj commented at 12:43 pm on July 17, 2018: member

    Let’s remove it then. I prefer having this test, TBH.
11. MarcoFalke restored the branch on Jul 17, 2018
12. MarcoFalke reopened this on Jul 17, 2018

    ---

13. MarcoFalke removed the label Up for grabs on Jul 17, 2018
14. MarcoFalke added this to the milestone 0.17.0 on Jul 17, 2018
15. 
    DrahtBot commented at 4:06 pm on July 17, 2018: member

    • #13621 (Check for datadir after the config files were read by Flowdalic)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

16. qa: Temporarily disable test that reads the default datadir location fabe28a0cd
17. MarcoFalke force-pushed on Jul 17, 2018
18. MarcoFalke removed this from the milestone 0.17.0 on Jul 17, 2018
19. 
    laanwj commented at 6:36 pm on July 17, 2018: member

    utACK fabe28a0cdcfa13e0e595a0905e3642a960d3077
20. laanwj merged this on Jul 18, 2018
21. laanwj closed this on Jul 18, 2018

    ---

22. laanwj referenced this in commit 9d26b690e7 on Jul 18, 2018
23. MarcoFalke deleted the branch on Jul 18, 2018
24. MarcoFalke referenced this in commit a7a6f1ff41 on Apr 22, 2020
25. sidhujag referenced this in commit be86c360ce on Apr 23, 2020
26. MarcoFalke locked this on Sep 8, 2021

Contributors
MarcoFalke laanwj DrahtBot

Labels
Tests