Reorder AppInit2 #1369

pull sipa wants to merge 1 commits into bitcoin:master from sipa:bootorder changing 1 files +204 −194

sipa commented at 3:17 PM on May 21, 2012: member
This reorders AppInit2 into 10 sections:
1. basic setup (OS stuff, signal handlers)
2. parameter interactions (softset)
3. interpreting options without side effects (just setting internal variables)
4. application initialization (datadir lock, daemonize, pidfile, log file)
5. network initialization (network params, proxy, binding)
6. load blockchain
7. load wallet
8. import blocks (-loadblock=)
9. load peers
10. start node/rpc threads
11. finished
This means invalid configurations will be detected as soon as possible (in particular, before loading the block chain).
laanwj commented at 3:23 PM on May 21, 2012: member

Hmm the comment about bitcoin-qt storing settings in wallet can be changed, as that's deprecated. It now uses its own settings store, and moves the settings from the wallet on first run. The support for wallet options is only for backward compatibility.
jgarzik commented at 3:27 PM on May 21, 2012: contributor

ACK

Reorder AppInit2

This reorders AppInit2 into 10 sections:
1)  basic setup (OS stuff, signal handlers)
2)  parameter interactions (softset)
3)  interpreting options without side effects (just setting internal variables)
4)  application initialization (datadir lock, daemonize, pidfile, log file)
5)  network initialization (network params, proxy, binding)
6)  load blockchain
7)  load wallet
8)  import blocks (-loadblock=)
9)  load peers
10) start node/rpc threads
11) finished

This means invalid configurations will be detected as soon as possible
(in particular, before loading the block chain).

7d80d2e3d7

sipa commented at 4:48 PM on May 21, 2012: member

@laanwj removed comment
laanwj commented at 5:01 PM on May 21, 2012: member

ACK
sipa referenced this in commit fa638ec8af on May 22, 2012
sipa merged this on May 22, 2012
sipa closed this on May 22, 2012
coblee referenced this in commit 773ef3955c on Jul 17, 2012
sipa deleted the branch on Jun 23, 2017
suprnurd referenced this in commit d26916ad5b on Dec 5, 2017
lateminer referenced this in commit 55be41e75f on Jan 22, 2019
lateminer referenced this in commit bb9b762bb1 on May 6, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

sipa

laanwj

jgarzik