Attempts to resolve #1371
Define BOOST_SPIRIT_THREADSAFE at all json_spirit*.h inclusion sites #1372
pull jgarzik wants to merge 1 commits into bitcoin:master from jgarzik:json-threadsafe changing 6 files +5 −6-
jgarzik commented at 11:07 PM on May 21, 2012: contributor
-
gavinandresen commented at 2:13 AM on May 22, 2012: contributor
That does the trick!
#defining it before every #include seems error-prone, though-- maybe better to -DBOOST_SPIRIT_THREADSAFE in the makefiles ?
-
7b671f52e0
Define BOOST_SPIRIT_THREADSAFE in all makefiles
rather than at each include site. Fixes #1371
-
jgarzik commented at 2:28 AM on May 22, 2012: contributor
Updated commit to alter all the makefiles, though I'd argue that updating five makefiles -- four of which I cannot test -- might be a little error prone too ;)
-
laanwj commented at 6:44 AM on May 22, 2012: member
I don't think there is a way around having at least two makefiles (for qmake and make), but some day it'd be interesting to find the common parts of the makefiles and putting those in a single file that is included from all of them.
- gavinandresen referenced this in commit eef7c4a773 on May 22, 2012
- gavinandresen merged this on May 22, 2012
- gavinandresen closed this on May 22, 2012
- coblee referenced this in commit 9e9de6d611 on Jul 17, 2012
- jgarzik deleted the branch on Aug 24, 2014
- lateminer referenced this in commit 1f14037e91 on Jan 22, 2019
- lateminer referenced this in commit 59fdfee134 on May 6, 2020
- DrahtBot locked this on Sep 8, 2021
Contributors