[contrib] Support ARM and RISC-V symbol check #13724

pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:symbol-check-all changing 2 files +32 −29
  1. ken2812221 commented at 1:37 pm on July 20, 2018: contributor
    Solve the TODO in the gitian-descripter
  2. fanquake added the label Scripts and tools on Jul 20, 2018
  3. ken2812221 force-pushed on Jul 20, 2018
  4. fanquake requested review from laanwj on Jul 21, 2018
  5. DrahtBot commented at 1:18 pm on July 22, 2018: member
    • #14091 (Minor style enhacement in documentation by fedsten)
    • #14066 (gitian-linux: Build binaries for 64-bit POWER by luke-jr)
    • #14065 (Symbol checks for ARM and RISC-V by luke-jr)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. laanwj commented at 2:42 pm on July 22, 2018: member
    Thanks for adding this!
  7. ken2812221 force-pushed on Jul 22, 2018
  8. MarcoFalke added the label Needs gitian build on Jul 22, 2018
  9. laanwj commented at 3:07 pm on July 22, 2018: member

    utACK 8f62ece7c1dddc4f69141d884b7c1863776c4fa7

    (though as it is dependent on #13665, this should only go in after the 0.17 branch-off)

  10. ken2812221 commented at 3:14 pm on July 22, 2018: contributor
    #13665 is not ready to merge since it would export a lot of symbols.
  11. MarcoFalke commented at 6:05 pm on July 22, 2018: member

    Have you run the symbol check after cross compilation? It seems to fail for me:

     0  CXXLD    test/test_bitcoin_fuzzy
 1  CXXLD    bitcoind
 2  CXXLD    bitcoin-cli
 3  CXXLD    bitcoin-tx
 4  CXXLD    test/test_bitcoin
 5  AR       qt/libbitcoinqt.a
 6  OBJCXXLD qt/bitcoin-qt
 7make[2]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-arm-linux-gnueabihf/src'
 8make[1]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-arm-linux-gnueabihf/src'
 9Making all in doc/man
10make[1]: Entering directory '/home/ubuntu/build/bitcoin/distsrc-arm-linux-gnueabihf/doc/man'
11make[1]: Nothing to be done for 'all'.
12make[1]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-arm-linux-gnueabihf/doc/man'
13make[1]: Entering directory '/home/ubuntu/build/bitcoin/distsrc-arm-linux-gnueabihf'
14make[1]: Nothing to be done for 'all-am'.
15make[1]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-arm-linux-gnueabihf'
16+ make -j9 -C src check-security
17make: Entering directory '/home/ubuntu/build/bitcoin/distsrc-arm-linux-gnueabihf/src'
18Checking binary security...
19make: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-arm-linux-gnueabihf/src'
20+ make -j9 -C src check-symbols
21make: Entering directory '/home/ubuntu/build/bitcoin/distsrc-arm-linux-gnueabihf/src'
22Checking glibc back compat...
23qt/bitcoin-qt: export of symbol _bss_end__ not allowed
24qt/bitcoin-qt: export of symbol __bss_end__ not allowed
25qt/bitcoin-qt: export of symbol __bss_start__ not allowed
26qt/bitcoin-qt: export of symbol __end__ not allowed
27make: *** [check-symbols] Error 1
28Makefile:10512: recipe for target 'check-symbols' failed
29make: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-arm-linux-gnueabihf/src'
  12. DrahtBot removed the label Needs gitian build on Jul 22, 2018
  13. ken2812221 force-pushed on Jul 23, 2018
  14. ken2812221 commented at 5:01 am on July 23, 2018: contributor
    @MarcoFalke Fixed. Sorry about not testing before I commited. I’ve tested 85ec33a35dfec2cc3b2e0decb5e184650caecdef (master + 60976f2) that can successfully do gitian build.
  15. MarcoFalke deleted a comment on Jul 23, 2018
  16. MarcoFalke added the label Needs gitian build on Jul 23, 2018
  17. DrahtBot removed the label Needs gitian build on Jul 23, 2018
  18. laanwj added this to the milestone 0.18.0 on Aug 2, 2018
  19. laanwj commented at 6:34 pm on August 16, 2018: member
    Needs rebase after #13665
  20. MarcoFalke deleted a comment on Aug 16, 2018
  21. MarcoFalke added the label Needs gitian build on Aug 16, 2018
  22. DrahtBot added the label Needs rebase on Aug 16, 2018
  23. ken2812221 force-pushed on Aug 16, 2018
  24. ken2812221 commented at 7:04 pm on August 16, 2018: contributor
    Need to skip RISC-V for now, the linker would export so many symbols.
  25. DrahtBot removed the label Needs rebase on Aug 16, 2018
  26. DrahtBot removed the label Needs gitian build on Aug 17, 2018
  27. MarcoFalke deleted a comment on Aug 17, 2018
  28. MarcoFalke added the label Needs gitian build on Aug 17, 2018
  29. DrahtBot commented at 8:13 pm on August 21, 2018: member

    Gitian builds for commit 4732fa133abdf374790825abbf1bbf56819cc806 (master):

    Gitian builds for commit 73a989af091d816b5029706b7124fd74d7a7f9b2 (master and this pull):

  30. DrahtBot removed the label Needs gitian build on Aug 21, 2018
  31. laanwj commented at 11:35 am on August 23, 2018: member

    Need to skip RISC-V for now, the linker would export so many symbols.

    FWIW checking the imports (against symbol versions) is much more important than checking the exports, as that’s what prevents binary incompatibilities.

  32. ken2812221 force-pushed on Aug 25, 2018
  33. ken2812221 force-pushed on Aug 25, 2018
  34. ken2812221 force-pushed on Aug 25, 2018
  35. [contrib] Support ARM and RISC-V symbol check c516c3a770
  36. ken2812221 force-pushed on Aug 25, 2018
  37. laanwj commented at 2:49 pm on August 25, 2018: member
    utACK c516c3a770e93dcd283dc4a9275cba88221d0e3a
  38. luke-jr commented at 7:01 pm on August 25, 2018: member
    Hmm, didn’t see this sooner. FWIW, I have another alternative to this we can evaluate.
  39. laanwj commented at 10:58 am on August 31, 2018: member
    I’m going ahead and merging this, @luke-jr please rebase your stuff on top.
  40. laanwj merged this on Aug 31, 2018
  41. laanwj closed this on Aug 31, 2018
  42. laanwj referenced this in commit 48ed386fa6 on Aug 31, 2018
  43. ken2812221 deleted the branch on Aug 31, 2018
  44. Munkybooty referenced this in commit 83e04fef3b on Jun 30, 2021
  45. Munkybooty referenced this in commit 51acbb64a0 on Jul 2, 2021
  46. Munkybooty referenced this in commit f5a46e294f on Jul 2, 2021
  47. DrahtBot locked this on Sep 8, 2021


ken2812221 DrahtBot laanwj MarcoFalke luke-jr


laanwj

Labels
Scripts and tools

Milestone
0.18.0

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 06:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me