--disable-asm doesn't seem to actually disable the new assembly optimisations.
Assembly optimisations are compiled even with --disable-asm #13759
issue luke-jr opened this issue on July 25, 2018-
luke-jr commented at 4:18 PM on July 25, 2018: member
- MarcoFalke added this to the milestone 0.17.0 on Jul 25, 2018
- MarcoFalke added the label Build system on Jul 25, 2018
- MarcoFalke removed this from the milestone 0.17.0 on Aug 2, 2018
-
sipa commented at 6:32 AM on August 8, 2018: member
The only cryptographic code written in assembly is the sse4 1-way variable-length SHA256 code introduced in #10821, and that's what
--disable-asmcontrols. The newer optimized code (introduced in #13191, #13393, and #13386) is written in C++ with intrinsics.I don't mind changing the scope of
--disable-asmto include these as well, but perhaps it should be renamed. The original reason for allowing the asm code to be disabled was that it was introduced relatively late in the 0.16 release cycle, and very hard to review. Those arguments don't apply as much to the intrinsics based code, I believe.Thinking about it - apart from reviewability - are there any reasons you'd want to disable these? If there are concerns about their correctness, we shouldn't be building by default in releases. If there aren't, we should probably just remove the compile flag.
- MarcoFalke closed this on Apr 26, 2019
- MarcoFalke referenced this in commit b1e013e4fa on Apr 26, 2019
- sidhujag referenced this in commit 15d0fe0761 on Apr 27, 2019
- codablock referenced this in commit b5ea6638fc on Oct 1, 2019
- codablock referenced this in commit 4bfc6ab303 on Oct 1, 2019
- barrystyle referenced this in commit a2b41857d1 on Jan 22, 2020
- DrahtBot locked this on Dec 16, 2021
Labels