This pull request is a subset of pull #1311. This change adds the command line option "-logtxpeer", which when chosen, will cause the peer to be reported for every transaction received, including invalid transactions.
As this is useful only for debugging, and not needed for general use of bitcoin, the option is not displayed in the syntax output, but only found when browsing the code.
640 | @@ -595,9 +641,9 @@ bool CTxMemPool::accept(CTxDB& txdb, CTransaction &tx, bool fCheckInputs, 641 | if (ptxOld) 642 | EraseFromWallets(ptxOld->GetHash()); 643 | 644 | - printf("CTxMemPool::accept() : accepted %s (poolsz %u)\n", 645 | - hash.ToString().substr(0,10).c_str(), 646 | - mapTx.size()); 647 | + printf("mempool %lu: ", mapTx.size()); 648 | + printf("tx %s accepted ", hash.ToString().substr(0,10).c_str());
No need for two abbreviated lines instead of one :(
fixed.
580 | @@ -543,8 +581,12 @@ bool CTxMemPool::accept(CTxDB& txdb, CTransaction &tx, bool fCheckInputs, 581 | unsigned int nSize = ::GetSerializeSize(tx, SER_NETWORK, PROTOCOL_VERSION); 582 | 583 | // Don't accept it if it can't get into a block 584 | - if (nFees < tx.GetMinFee(1000, true, GMF_RELAY)) 585 | - return error("CTxMemPool::accept() : not enough fees");
Don't assume error() is simply printf && return false
Fair point. Fixed. Using error() now.
Consensus similar to #1375: "txnode" global is not worth it, and is not MT friendly.
The concept seems agreeable -- at times, various IRC denizens have expressed an interest in logging the IP associated with a particular behavior.
It might be easier to approach this from another angle: maybe in the ProcessMessage() loop, with ready, locked access to "pfrom", some useful logging may be obtained.