contrib: add gitian build support for github pull request #13765

pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:gitian-build-pull changing 1 files +10 −1

ken2812221 commented at 11:33 AM on July 26, 2018: contributor
- Add -p or --pull to specify the version is github pull request number
- ./gitian-build.py -bpDn test 13765 should work. This is helpful for someone want to try cross compiling.
fanquake added the label Scripts and tools on Jul 26, 2018
ken2812221 force-pushed on Jul 29, 2018

in contrib/gitian-build.py:138 in bbf64d5337 outdated

 134 | @@ -135,6 +135,7 @@ def main():
 135 |  
 136 |      parser = argparse.ArgumentParser(usage='%(prog)s [options] signer version')
 137 |      parser.add_argument('-c', '--commit', action='store_true', dest='commit', help='Indicate that the version argument is for a commit or branch')
 138 | +    parser.add_argument('-p', '--pull', action='store_true', dest='pull', help='Indicate that the version argument is number of a github repository pull request')

kallewoof commented at 7:21 PM on July 30, 2018:

Nit/typo: is the number of a (the)

kallewoof commented at 7:22 PM on July 30, 2018: member

utACK bbf64d53374edb1be5dc7bd016369276addf3f56
contrib: Support github pull request gitian-build 46f8345370
ken2812221 force-pushed on Jul 31, 2018

in contrib/gitian-build.py:214 in 46f8345370

 210 | +        subprocess.check_call(['git', 'fetch', args.url, 'refs/pull/'+args.version+'/merge'])
 211 | +        os.chdir('../gitian-builder/inputs/bitcoin')
 212 | +        subprocess.check_call(['git', 'fetch', args.url, 'refs/pull/'+args.version+'/merge'])
 213 | +        args.commit = subprocess.check_output(['git', 'show', '-s', '--format=%H', 'FETCH_HEAD'], universal_newlines=True).strip()
 214 | +        args.version = 'pull-' + args.version
 215 | +    print(args.commit)

laanwj commented at 2:55 PM on August 7, 2018:

is this intended or a left-over debug statement?

ken2812221 commented at 12:44 AM on August 9, 2018:

That's intended, move from the above one.

laanwj commented at 9:47 AM on August 22, 2018: member

utACK 46f83453701fc6116d97de6a16986388ba63488f in that case
laanwj merged this on Aug 22, 2018
laanwj closed this on Aug 22, 2018
laanwj referenced this in commit a5fc1aa04d on Aug 22, 2018
ken2812221 deleted the branch on Aug 22, 2018
Munkybooty referenced this in commit e64ed43280 on Jun 30, 2021
Munkybooty referenced this in commit f177c1b393 on Jun 30, 2021
Munkybooty referenced this in commit 53e2d3244e on Jul 1, 2021
Munkybooty referenced this in commit 3dad9b32a1 on Jul 1, 2021
PastaPastaPasta referenced this in commit 8fc7b749dd on Jul 18, 2021
PastaPastaPasta referenced this in commit fbcbab494c on Jul 18, 2021
PastaPastaPasta referenced this in commit 3ef74ac800 on Jul 20, 2021
PastaPastaPasta referenced this in commit b416b41eee on Jul 20, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels