Fix osslsigncode compile issue in gitian-build #13782

pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:patch-1 changing 1 files +2 −1
  1. ken2812221 commented at 3:29 PM on July 27, 2018: contributor

    Install libssl1.0-dev that is compatible with osslsigncode.

    Fixes #13762

    Verifed that this gitian descriptor file can sign 0.16.2rc2.

  2. fanquake added the label Build system on Jul 27, 2018
  3. MarcoFalke added this to the milestone 0.17.0 on Jul 27, 2018
  4. MarcoFalke commented at 3:35 PM on July 27, 2018: member

    utACK 39126a3b053372e440e9699bed41c3f53bf632fd

  5. jonasschnelli commented at 7:39 AM on July 30, 2018: contributor

    utACK 39126a3b053372e440e9699bed41c3f53bf632fd

  6. laanwj commented at 11:37 AM on July 30, 2018: member

    utACK But please add a comment that this is a workaround that can be removed once osslsigncode supports the new API. We've had a case recently where we didn't know why a certain specific version of a lib was enforced anymore.

  7. Fix osslsigncode compile issue in gitian-build 284f424d5a
  8. ken2812221 force-pushed on Jul 30, 2018
  9. ken2812221 commented at 3:45 PM on July 30, 2018: contributor

    @laanwj Added

  10. MarcoFalke merged this on Jul 30, 2018
  11. MarcoFalke closed this on Jul 30, 2018

  12. MarcoFalke referenced this in commit 8284f1dc40 on Jul 30, 2018
  13. underdarkskies commented at 8:17 PM on July 30, 2018: none

    @MarcoFalke @laanwj just as a heads up for the codesigner, compiling osslsigncode with curl (needed for detached-sig-create.sh) creates an in compatibility between curl which requires libssl-dev and libssl1.0-dev. Therefore that compilation of osslsigncode needs to be performed on ubuntu 16.04. I'm still not sure why the gitianbuild compiles osslsigncode without curl, as this requires two seperate compiles still.

  14. ken2812221 deleted the branch on Jul 30, 2018
  15. PastaPastaPasta referenced this in commit 0240109a27 on Jul 29, 2020
  16. PastaPastaPasta referenced this in commit 619f7fb862 on Jul 29, 2020
  17. xdustinface referenced this in commit 8e815b2b43 on Dec 21, 2020
  18. PastaPastaPasta referenced this in commit 52336be438 on Dec 27, 2020
  19. PastaPastaPasta referenced this in commit 5ed48eaa73 on Jun 27, 2021
  20. PastaPastaPasta referenced this in commit b57f9a9741 on Jun 28, 2021
  21. PastaPastaPasta referenced this in commit 9288bc9e2c on Jun 29, 2021
  22. PastaPastaPasta referenced this in commit 5593b07fac on Jun 29, 2021
  23. PastaPastaPasta referenced this in commit cdc40ccb6d on Jun 29, 2021
  24. PastaPastaPasta referenced this in commit ee0a76d4ba on Jun 29, 2021
  25. PastaPastaPasta referenced this in commit 034cadfcd8 on Jun 29, 2021
  26. PastaPastaPasta referenced this in commit f9a16ff05d on Jul 1, 2021
  27. CryptoCentric referenced this in commit 67113cdf99 on Jul 3, 2021
  28. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-20 09:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me