bench_bitcoin hits assert in coin selection #13813

1. 
   MarcoFalke commented at 7:46 PM on July 30, 2018: member

   Output with current master:

   bench_bitcoin: bench/coin_selection.cpp:53: void CoinSelection(benchmark::State&): Assertion `success' failed.
   

2. MarcoFalke added this to the milestone 0.17.0 on Jul 30, 2018
3. MarcoFalke added the label Tests on Jul 30, 2018
4. MarcoFalke added the label good first issue on Jul 30, 2018
5. 
   laanwj commented at 4:08 PM on July 31, 2018: member

   crap, when did this happen? we don't test bench_bitcoin anywhere in Travis do we?

6. 
   MarcoFalke commented at 5:37 PM on July 31, 2018: member

   I believe this was introduced in "Use destination groups instead of coins in coin select #12257" @kallewoof mind to take a look here, since you seem to be more familiar with how coin selection currently works than me.

7. 
   laanwj commented at 5:38 PM on July 31, 2018: member

   yep

   59d6f7b4e2f847ec1f2ff46c84e6157655984f85 is the first bad commit
   commit 59d6f7b4e2f847ec1f2ff46c84e6157655984f85
   Author: Karl-Johan Alm <karljohan-alm@garage.co.jp>
   Date:   Thu Jul 19 11:45:26 2018 +0900
   
       wallet: Switch to using output groups instead of coins in coin selection
   
   :040000 040000 b9cdb9dca5f1827f82e7586d5c051497f7d34e11 0515cb1b01f5e1538efdc5caead1c0a492bb532c M      src
   

8. 
   kallewoof commented at 6:26 PM on July 31, 2018: member

   Will check in ~12 hours!

9. 
   achow101 commented at 6:27 PM on July 31, 2018: member

   The groups are failing the eligibility filter. I will open a PR fixing this soon.

10. MarcoFalke referenced this in commit 0fb9c87815 on Jul 31, 2018
11. MarcoFalke closed this on Jul 31, 2018

    ---

12. UdjinM6 referenced this in commit fee7adbd45 on Jun 29, 2021
13. UdjinM6 referenced this in commit 808b83347b on Jun 29, 2021
14. UdjinM6 referenced this in commit c503c895de on Jul 1, 2021
15. UdjinM6 referenced this in commit aca6120124 on Jul 2, 2021
16. UdjinM6 referenced this in commit 1cbeebda22 on Jul 2, 2021
17. MarcoFalke locked this on Sep 8, 2021
18. gades referenced this in commit f12902d9f9 on May 31, 2022

Milestone
0.17.0