qa: CoinSelection benchmark assert fails #13831

issue jamesob opened this issue on August 1, 2018

jamesob commented at 2:46 PM on August 1, 2018: member

$ ./src/bench/bench_bitcoin -filter=CoinSelection

# Benchmark, evals, iterations, total, min, max, median
bench_bitcoin: bench/coin_selection.cpp:54: void CoinSelection(benchmark::State&): Assertion `success' failed.
[1]    24547 abort (core dumped)  ./src/bench/bench_bitcoin -filter=CoinSelection

$ cat <(git rev-parse HEAD) <(uname -a) <(gcc --version)

4d550ffab64d79a44fcaa76f6e30c28f01614d3f
Linux james 4.4.0-119-generic [#143](/bitcoin-bitcoin/143/)+jamesob SMP Mon Apr 16 21:47:24 EDT 2018 x86_64 x86_64 x86_64 GNU/Linux
gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609

Based on some cursory debugging, this conditional is causing the BnB routine to return false which then fails the assert.

ken2812221 commented at 2:52 PM on August 1, 2018: contributor

Should be fixed by #13822
jamesob commented at 2:58 PM on August 1, 2018: member

Confirmed fixed. Thanks for the pointer, @ken2812221.
jamesob closed this on Aug 1, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

jamesob

ken2812221

Linked (view graph)

#143 Fix deadlocks in getaccountaddress, setaccount, sendfrom RPC calls