Travis test for commit range #13865

issue skeees opened this issue on August 3, 2018
  1. skeees commented at 3:21 PM on August 3, 2018: contributor

    When a pr contains multiple commits, it would be good to test that every commit in that range at the very least builds and passes unit tests (current travis just runs against the branch head). Having no broken commits preserves git bisectability.

    I'm not a travis expert so just leaving this here, for maybe someone who is more familiar to pick up.

    This is probably also a "good first issue"

  2. fanquake added the label Tests on Aug 4, 2018
  3. fanquake added the label good first issue on Aug 4, 2018
  4. dongcarl commented at 8:03 AM on August 14, 2018: member

    Would git rebase --exec "<test cmd>" accomplish this?

  5. prusnak commented at 6:56 PM on August 26, 2018: contributor

    Not sure if this is possible as this would exponentially increase requirements put on Travis build servers if more projects used this. It's a good idea, nevertheless.

  6. piraces commented at 11:27 AM on August 29, 2018: none

    I think I can work on this. I will think about @dongcarl idea, and other possible alternatives.

  7. piraces commented at 4:41 PM on August 29, 2018: none

    I have researched about it, and Travis don't support this feature, as we can see in this feature request: building every revision

    I have also tried in my own fork to execute git rebase --exec "<tests scripts>" but I don't know where to exactly put this command. I think the best place to execute it's actually .travis/lint_05_before_script.sh

    And pass to the exec argument the desired tests to run. What do you think about that?

  8. MarcoFalke commented at 4:49 PM on August 29, 2018: member

    Indeed, if you want every commit to run travis, you'd have to push them individually.

  9. piraces commented at 6:14 AM on August 30, 2018: none

    @MarcoFalke Actually yes... However, I will watch the referenced feature request in travis-ci, for some resolution.

  10. D4nte commented at 11:34 AM on October 7, 2019: none

    On Circle CI API you can trigger a new build and pass the commit SHA: https://circleci.com/docs/api/#trigger-a-new-job

    Maybe the same is possible for Travis?

    In this case, when opening a PR we could create a GitHub Action that triggers a build for each commit in the PR.

    If my understanding of GitHub is correct, doing so would show the green ticks against each commit in GitHub (GitHub remembers checks per commit hash).

  11. MarcoFalke removed the label good first issue on Apr 27, 2020
  12. MarcoFalke commented at 12:48 AM on April 27, 2020: member

    The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

    Closing due to lack of interest. Pull requests with improvements are always welcome.

  13. MarcoFalke closed this on Apr 27, 2020

  14. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 09:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me