wallet: Catch filesystem_error and raise InitError #13876

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1808-walletFsError changing 1 files +6 −1
  1. MarcoFalke commented at 4:06 PM on August 4, 2018: member

    Fixes #13754 by restoring the previous behaviour

  2. wallet: Catch filesystem_error and raise InitError fa8527ffec
  3. MarcoFalke added the label Wallet on Aug 4, 2018
  4. MarcoFalke added the label Needs gitian build on Aug 4, 2018
  5. DrahtBot commented at 4:25 PM on August 4, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:

    • #11911 (Free CDBEnv instances when not in use by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. MarcoFalke commented at 4:49 PM on August 4, 2018: member

    Before: <img width="509" alt="schermafbeelding 2018-07-24 om 17 43 26" src="https://user-images.githubusercontent.com/10217/43150605-9cf32192-8f6a-11e8-9333-87d074c8dd35.png">

    After:

    screenshot from 2018-08-04 12-48-17

    Using:

    6f7a41d357d5e3fb4614fec0280477f3e71bbda1bb28f32461b1cc2c418c0c4d bitcoin-0.16.99-win64.zip https://transfer.sh/MPEy5/bitcoin-0.16.99-win64.zip

  7. MarcoFalke added this to the milestone 0.17.0 on Aug 4, 2018
  8. laanwj commented at 6:49 PM on August 4, 2018: member

    certainly better utACK fa8527ffeced3f898e8f205483ef0ea7c51a9178

  9. DrahtBot commented at 5:02 AM on August 5, 2018: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 2b67354aa584c4aabae049a67767ac7b70e2d01a (master):

    Gitian builds for commit 04cb409e2c353fce1e6b02e08ae7e94c03b53185 (master and this pull):

  10. DrahtBot removed the label Needs gitian build on Aug 5, 2018
  11. MarcoFalke removed this from the milestone 0.17.0 on Aug 5, 2018
  12. laanwj added this to the milestone 0.17.0 on Aug 8, 2018
  13. laanwj commented at 1:33 PM on August 8, 2018: member

    Adding to 0.17.0 milestone as I think this is a regression?

  14. MarcoFalke commented at 1:59 PM on August 8, 2018: member

    Regression in a sense that it throws a useless error as opposed to something more helpful.

  15. MarcoFalke commented at 2:06 PM on August 8, 2018: member

    Ideally we'd handle runtime errors more sanely and automatic as opposed to splattered catch clauses all over the place. Imo we should provide a copy-paste able stacktrace on runtime errors and a link to submit an issue with all the debugging information attached.

    E.g. https://github.com/bitcoin/bitcoin/issues/new?title=VERSION%20MODULE%20runtime%20error&body=stacktrace%20and%20operating_sytem%20information

  16. MarcoFalke commented at 2:06 PM on August 8, 2018: member

    @Sjors Mind to take a quick look at the patch, please?

  17. Sjors commented at 2:54 PM on August 8, 2018: member

    For some reason this build throws an unexpected error for me, even when launching without -wallet param (master does start):

    <img width="1010" alt="schermafbeelding 2018-08-08 om 16 52 06" src="https://user-images.githubusercontent.com/10217/43845154-a0b0b2f0-9b2b-11e8-844f-a7a17057e652.png">

  18. MarcoFalke commented at 4:58 PM on August 8, 2018: member

    @Sjors Interesting. I didn't change that part of the code at all. This comes very early in initialization:

    https://github.com/bitcoin/bitcoin/blob/df9f71274645a917e2578c52a1c59745bce8112d/src/init.cpp#L1183

    Are you sure you compare the "Gitian builds for commit 2b67354 (master)" with "Gitian builds for commit 04cb409 (master and this pull)"?

  19. MarcoFalke commented at 8:12 PM on August 8, 2018: member

    I just tried again and they work for me with a fresh account:

    screenshot from 2018-08-08 16-09-56

  20. Sjors commented at 10:44 AM on August 9, 2018: member

    @MarcoFalke I downloaded it (and master) straight from @DrahtBot and the link you posted (only your version). It's weird, but given that my error is created elsewhere in the code, and others don't see it, maybe just ignore?

  21. ken2812221 commented at 11:09 AM on August 9, 2018: contributor

    Tested ACK fa8527ffeced3f898e8f205483ef0ea7c51a9178

    Although the message is a mess if the system setting is not English.

    image

  22. MarcoFalke merged this on Aug 9, 2018
  23. MarcoFalke closed this on Aug 9, 2018
  24. MarcoFalke referenced this in commit 8eb9870052 on Aug 9, 2018
  25. MarcoFalke deleted the branch on Aug 9, 2018
  26. jasonbcox referenced this in commit 5c1f643c9f on Sep 13, 2019
  27. PastaPastaPasta referenced this in commit a992e025f1 on Feb 2, 2021
  28. PastaPastaPasta referenced this in commit ce89dc7c58 on Feb 3, 2021
  29. PastaPastaPasta referenced this in commit b08e60e529 on Feb 4, 2021
  30. DrahtBot locked this on Sep 8, 2021
Contributors
MarcoFalkeDrahtBotlaanwjSjorsken2812221
Labels
Wallet

Milestone
0.17.0

Linked (view graph)
#13754 Windows crashes for -wallet=你好
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me