[RPC] Remove getinfo deprecation warning #13891

1. 
   jnewbery commented at 3:44 PM on August 6, 2018: member

   getinfo was removed in V0.16. A removal warning message was left in place to tell users that the method had been removed. We can remove that entirely in V0.18.

2. [RPC] Remove getinfo deprecation warning b2f23c4153
3. jnewbery renamed this:
   [DO NOT REMOVE UNTIL V0.18] [RPC] Remove getinfo deprecation warning
   [DO NOT MERGE UNTIL V0.18] [RPC] Remove getinfo deprecation warning
   on Aug 6, 2018
4. fanquake added this to the milestone 0.18.0 on Aug 6, 2018
5. fanquake added the label RPC/REST/ZMQ on Aug 6, 2018
6. 
   achow101 commented at 11:06 PM on August 6, 2018: member

   utACK b2f23c41538eaadd71c373ada75dd3a982eeb8bf

7. 
   domob1812 commented at 7:38 AM on August 7, 2018: contributor

   utACK b2f23c41538eaadd71c373ada75dd3a982eeb8bf

8. 
   laanwj commented at 11:32 AM on August 8, 2018: member

   ~0 on this, wouldn't mind letting this wait another major version, but also ok with removing it if everyone thinks that this is common knowledge now

9. 
   DrahtBot commented at 1:32 AM on August 12, 2018: member

   <!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:

   • #13945 (Refactoring CRPCCommand with enum category by isghe)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

10. 
    jnewbery commented at 11:05 AM on August 14, 2018: member

    wouldn't mind letting this wait another major version

    This won't be in a release until V0.18, which should be Feb/March 2019. getinfo was first marked as deprecated in V0.14 (https://github.com/bitcoin/bitcoin/pull/8780) and removed in V0.16 (https://github.com/bitcoin/bitcoin/pull/10838), with a deprecation warning added in that release (https://github.com/bitcoin/bitcoin/pull/12198).

    Two releases saying a feature is going to be deprecated (v0.14 & v0.15), then two releases saying the feature has been deprecated (v0.16 and v0.17) seems like plenty of warning to me.

11. jnewbery renamed this:
    [DO NOT MERGE UNTIL V0.18] [RPC] Remove getinfo deprecation warning
    [RPC] Remove getinfo deprecation warning
    on Aug 14, 2018
12. 
    jnewbery commented at 11:05 AM on August 14, 2018: member

    V0.17 has been branched. This is ready for review/merge.

13. 
    ken2812221 commented at 11:09 AM on August 14, 2018: contributor

    utACK b2f23c4

14. ken2812221 referenced this in commit ef98e122ca on Aug 15, 2018
15. laanwj merged this on Aug 15, 2018
16. laanwj closed this on Aug 15, 2018

    ---

17. deadalnix referenced this in commit cd6a6524c3 on Apr 14, 2020
18. Munkybooty referenced this in commit 1bebcc1642 on Jun 29, 2021
19. Munkybooty referenced this in commit acb90230de on Jun 30, 2021
20. Munkybooty referenced this in commit c0cb397327 on Jul 2, 2021
21. Munkybooty referenced this in commit 6af03a3125 on Jul 2, 2021
22. MarcoFalke locked this on Sep 8, 2021

Contributors

jnewberyachow101domob1812laanwjDrahtBotken2812221

Milestone
0.18.0