qa: wait_for_verack by default #13916

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1808-qaWaitForVerack changing 21 files +11 −56
  1. MarcoFalke commented at 9:23 PM on August 8, 2018: member

    This removes the need to do so manually every time a connection is added.

  2. qa: wait_for_verack by default fa5587fe71
  3. MarcoFalke commented at 9:23 PM on August 8, 2018: member

    Requested by @jnewbery in #13915 (review)

  4. MarcoFalke added the label Tests on Aug 8, 2018
  5. jnewbery commented at 9:43 PM on August 8, 2018: member

    Tested ACK fa5587fe71ce041dc69cb0d46697975bb51ef1f6. I haven't run the extended_tests. Someone should do that before merge probably.

    +11 -56 :tada:

  6. MarcoFalke added this to the milestone 0.17.0 on Aug 8, 2018
  7. MarcoFalke commented at 9:45 PM on August 8, 2018: member

    Assigned 0.17, so that later test backports don't start to conflict with everything

  8. DrahtBot commented at 11:07 PM on August 8, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:

    • #12493 ([wallet] Reopen CDBEnv after encryption instead of shutting down by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  9. kallewoof approved
  10. kallewoof commented at 4:28 AM on August 9, 2018: member

    Nice.

    utACK fa5587fe71ce041dc69cb0d46697975bb51ef1f6

  11. conscott commented at 12:02 PM on August 9, 2018: contributor

    utACK fa5587fe71ce041dc69cb0d46697975bb51ef1f6

  12. MarcoFalke merged this on Aug 9, 2018
  13. MarcoFalke closed this on Aug 9, 2018

  14. MarcoFalke referenced this in commit 8ac7125d59 on Aug 9, 2018
  15. MarcoFalke deleted the branch on Aug 9, 2018
  16. UdjinM6 referenced this in commit 3f5a9c2f52 on Jul 4, 2021
  17. UdjinM6 referenced this in commit 4991435c6a on Jul 6, 2021
  18. UdjinM6 referenced this in commit e1497f67b2 on Jul 6, 2021
  19. DrahtBot locked this on Sep 8, 2021
Labels

Milestone
0.17.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me