Hardcoded seeds update pre-0.17 branch #13951

pull laanwj wants to merge 3 commits into bitcoin:master from laanwj:2018_08_hardcoded_seeds changing 4 files +1938 −2452
  1. laanwj commented at 11:59 AM on August 13, 2018: member
  2. contrib: in makeseeds, add 0.16.x to PATTERN_AGENT, remove 0.13.x 61c0d3b9aa
  3. net: Update hardcoded seeds
    Pre-0.17 branch hardcoded seeds update.
    825fb02ef1
  4. laanwj added the label P2P on Aug 13, 2018
  5. laanwj added this to the milestone 0.17.0 on Aug 13, 2018
  6. MarcoFalke commented at 12:54 PM on August 13, 2018: member

    utACK 825fb02ef1c716f930bc7c40a6acda5eaff2c40f (Did the same steps and confirmed that my result has a smaller diff against 825fb02ef1c716f930bc7c40a6acda5eaff2c40f, than against current master)

  7. MarcoFalke commented at 12:58 PM on August 13, 2018: member

    nit: Could add a commit to fix GetDesireableServiceFlags -> GetDesirableServiceFlags, since that is used in the code. Proposed diff:

    diff --git a/contrib/seeds/README.md b/contrib/seeds/README.md
    index 6dc277f298..502c20d0d6 100644
    --- a/contrib/seeds/README.md
    +++ b/contrib/seeds/README.md
    @@ -4,7 +4,7 @@ Utility to generate the seeds.txt list that is compiled into the client
     (see [src/chainparamsseeds.h](/src/chainparamsseeds.h) and other utilities in [contrib/seeds](/contrib/seeds)).
     
     Be sure to update `PATTERN_AGENT` in `makeseeds.py` to include the current version,
    -and remove old versions as necessary (at a minimum when GetDesireableServiceFlags
    +and remove old versions as necessary (at a minimum when GetDesirableServiceFlags
     changes its default return value, as those are the services which seeds are added
     to addrman with).
     
    
  8. contrib: fix GetDesirableServiceFlags typo in seeds/README.md 176aa5aa1d
  9. laanwj commented at 1:12 PM on August 13, 2018: member

    Thanks, added

  10. MarcoFalke commented at 1:13 PM on August 13, 2018: member

    re-ACK 176aa5aa1d944113161b99cf6c09b7dd3a5c684e

  11. ken2812221 referenced this in commit 8a9ffec0a2 on Aug 13, 2018
  12. laanwj merged this on Aug 13, 2018
  13. laanwj closed this on Aug 13, 2018

  14. MarcoFalke locked this on Sep 8, 2021
Contributors
Labels

Milestone
0.17.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me