Report minfeefilter value in getpeerinfo rpc #13987

1. 
   ajtowns commented at 2:50 am on August 16, 2018: member

   Lowering the minimum relay fee is only useful when many nodes in the p2p network also lower the fee, so to make it easier to understand progress on that front, this includes the value of the minfeefilter in getpeerinfo, so you at least have visibility to what fees your neighbours are currently accepting.
2. fanquake added the label P2P on Aug 16, 2018
3. 
   DrahtBot commented at 4:46 am on August 16, 2018: member

   • #13152 ([rpc] Add getnodeaddresses RPC command by chris-belcher)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   MarcoFalke commented at 10:57 am on August 16, 2018: member

   utACK 840aeb177220545adc7f9a3b3b0397b411bd9f41
5. in src/rpc/net.cpp:105 in 840aeb1772 outdated

   101@@ -102,6 +102,7 @@ static UniValue getpeerinfo(const JSONRPCRequest& request)
   102             "       ...\n"
   103             "    ],\n"
   104             "    \"whitelisted\": true|false, (boolean) Whether the peer is whitelisted\n"
   105+            "    \"minfee\": n,               (numeric) The minimum fee rate for transactions this peer accepts\n"
   

   ---

   ---

   

   promag commented at 3:35 pm on August 17, 2018:

   Could be minfeefilter to not clash with https://github.com/bitcoin/bitcoin/blob/3c8d1ae15352d5c92d5903536c8fe07f771e97a0/src/rpc/blockchain.cpp#L1720

   ---

   

   ajtowns commented at 11:23 am on August 27, 2018:

   This is a good idea, done.
6. 
   promag commented at 3:36 pm on August 17, 2018: member

   utACK 840aeb1.
7. 
   laanwj commented at 10:41 am on August 27, 2018: member

   @ajtowns please respond to @promag’s comment, if you don’t want to make the change that’s okay too, but merge is essentially blocked on your response
8. Report minfeefilter value in getpeerinfo rpc

   Lowering the minimum relay fee is only useful when many nodes in the
   p2p network also lower the fee, so to make it easier to understand
   progress on that front, this includes the value of the minfeefilter in
   getpeerinfo, so you at least have visibility to what fees your neighbours
   are currently accepting.

   5778bf95d9
9. ajtowns force-pushed on Aug 27, 2018
10. ken2812221 referenced this in commit 6667490466 on Aug 27, 2018
11. MarcoFalke merged this on Aug 27, 2018
12. MarcoFalke closed this on Aug 27, 2018

    ---

13. PastaPastaPasta referenced this in commit ee6ec6f671 on Jun 27, 2021
14. PastaPastaPasta referenced this in commit b6c29ad4f0 on Jun 28, 2021
15. PastaPastaPasta referenced this in commit 2f80a96816 on Jun 29, 2021
16. Munkybooty referenced this in commit db4a54e10d on Jun 30, 2021
17. PastaPastaPasta referenced this in commit 45773b68fa on Jul 18, 2021
18. DrahtBot locked this on Sep 8, 2021

Contributors
ajtowns DrahtBot MarcoFalke promag laanwj

Labels
P2P