Clean up the rpc method testmempoolaccept #14016

issue RHavar opened this issue on August 21, 2018
  1. RHavar commented at 5:44 PM on August 21, 2018: contributor

    Sorry I didn't see or comment in the initial PR for the RPC method testmempoolaccept, but I think the method could do with some finesse.

    1. Don't take an array of transactions

    1. Remove allowhighfees

    This really shouldn't be a parameter going in, it should be part of the output. e.g. highFeeAlert: true.

    1. Additional information like fees/sizes of the transaction (and ideally its entire ancestor cluster) should be returned, similar to what ever the mempool entry stuff has.
  2. promag commented at 6:44 PM on August 21, 2018: member

    IIRC the idea in supporting an array is to test transaction chaining, where transaction B spends an output of transaction A.

  3. RHavar commented at 11:02 PM on August 21, 2018: contributor

    Ah, that makes perfect sense. I'll cross if off the list

  4. fanquake added the label RPC/REST/ZMQ on Aug 22, 2018
  5. RHavar commented at 1:22 AM on August 27, 2018: contributor

    Another response field that would be very useful is if it could return information about the transactions that would need to be evicted for this transaction to be accepted in the mempool (i.e. rbf'd out transactions).

  6. RHavar commented at 4:19 PM on October 2, 2018: contributor

    Also I'm still not a huge fan of the array-of-transaction's going in. It really feels over-engineered especially as it's likely it'll never even get implemented. At the least I think it should be overloaded with a simplified style:

    testmempoolaccept $hex

    instead of needing to wrap it with a json array (And then unwrap the response)

  7. jnewbery commented at 6:04 PM on February 26, 2019: member

    Related: #13541

  8. glozow commented at 3:32 PM on March 9, 2022: member

    Looks like this has been resolved.

    ~1. Don't take an array of transactions~ I'm still not a huge fan of the array-of-transaction's going in. It really feels over-engineered especially as it's likely it'll never even get implemented.

    Has been implemented in #20833.

    1. Remove allowhighfees

    Removed in #15620.

    1. Additional information like fees/sizes of the transaction

    Added in #19940.

  9. MarcoFalke commented at 7:01 AM on March 10, 2022: member

    Closing for now. Please open a new issue for anything new or forgotten.

  10. MarcoFalke closed this on Mar 10, 2022

  11. DrahtBot locked this on Mar 10, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me