qa: Add some actual witness in rpc_rawtransaction #14052

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1808-rpcActualWitness changing 1 files +1 −1

MarcoFalke commented at 6:04 PM on August 24, 2018: member

The transaction was serialized with the witness flag but didn't include any witness, so add some dummy witness...
qa: Add some actual witness in rpc_rawtransaction fae040010d
MarcoFalke added the label Tests on Aug 24, 2018

in test/functional/rpc_rawtransaction.py:361 in fae040010d

 357 | @@ -358,7 +358,7 @@ def run_test(self):
 358 |  
 359 |          # decoderawtransaction tests
 360 |          # witness transaction
 361 | -        encrawtx = "010000000001010000000000000072c1a6a246ae63f74f931e8365e15a089c68d61900000000000000000000ffffffff0100e1f50500000000000000000000"
 362 | +        encrawtx = "010000000001010000000000000072c1a6a246ae63f74f931e8365e15a089c68d61900000000000000000000ffffffff0100e1f50500000000000102616100000000"

laanwj commented at 9:00 AM on August 27, 2018:

Could we prevent, somehow, that the old transaction without witness passes this test?

MarcoFalke commented at 11:15 AM on August 27, 2018:

Merging #14039 would prevent the test from passing.

laanwj commented at 3:01 PM on August 28, 2018: member

ACK fae040010deda9404b15b214cec2a099fb831253, tested that this makes #14039 pass
MarcoFalke referenced this in commit 8e9f851415 on Aug 28, 2018
MarcoFalke merged this on Aug 28, 2018
MarcoFalke closed this on Aug 28, 2018
MarcoFalke referenced this in commit 938cd446f2 on Oct 4, 2018
MarcoFalke referenced this in commit 7ff32a6b98 on Oct 25, 2018
toxeus referenced this in commit fd86abca6e on Nov 28, 2018
Munkybooty referenced this in commit 9d3acd6e41 on Jun 30, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

MarcoFalke

laanwj

Labels

Tests