No description provided.
export der always compressed #14102
pull fingera wants to merge 2 commits into bitcoin:master from fingera:3-export-der changing 2 files +16 −5-
fingera commented at 6:11 AM on August 30, 2018: contributor
-
always compressed 9bf6b1f2d2
-
laanwj commented at 6:16 AM on August 30, 2018: member
Please add rationale to your OP, why is this change?
Also please add at least a test for the new behavior
- randolf changes_requested
-
randolf commented at 6:28 AM on August 30, 2018: contributor
Please update the description of what this PR does (at present there is no description). Thank you.
-
fingera commented at 6:30 AM on August 30, 2018: contributor
BOOST_AUTO_TEST_CASE(key_priv_compress_tests) { CKey key; key.MakeNewKey(false); BOOST_CHECK(key.GetPrivKey().size() == CKey::PRIVATE_KEY_SIZE); key.MakeNewKey(true); BOOST_CHECK(key.GetPrivKey().size() == CKey::COMPRESSED_PRIVATE_KEY_SIZE); }
-
add test case 86c877d0d8
-
DrahtBot commented at 7:18 AM on August 30, 2018: member
<!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:
- #14047 (Add HKDF_HMAC256_L32 and method to negate a private key by jonasschnelli)
- #12461 (scripted-diff: Rename key size consts to be relative to their class by Empact)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
laanwj commented at 4:11 PM on September 10, 2018: member
Closing, as the goal here has not been explained
- laanwj closed this on Sep 10, 2018
-
fingera commented at 1:10 AM on September 11, 2018: contributor
it is a bug for ec_privkey_export_der
-
sipa commented at 1:25 AM on September 11, 2018: member
Please provide a longer rationale. The exported keys seem to work fine so far, so unless you can demonstrate there is a problem with them, this change seems pointless (and wrong; private keys with uncompressed pubkeys should use uncompressed DER in their export).
-
fingera commented at 1:37 AM on September 11, 2018: contributor
Is it changing ec_privkey_export_der? Delete another branch that will never be reached
-
- DrahtBot locked this on Sep 8, 2021
