qa: Read reject reasons from debug log, not p2p messages #14119

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1808-qaRejectLog changing 8 files +138 −191

MarcoFalke commented at 12:42 PM on August 31, 2018: member

For local testing we don't need to rely on p2p messages just to assert a reject reason.

Replace reading p2p messages with reading from the debug log file.
MarcoFalke added the label Tests on Aug 31, 2018
MarcoFalke force-pushed on Aug 31, 2018
MarcoFalke force-pushed on Aug 31, 2018
MarcoFalke force-pushed on Aug 31, 2018
MarcoFalke force-pushed on Aug 31, 2018
qa: Read reject reasons from debug log, not p2p messages fac3e22b18
MarcoFalke force-pushed on Aug 31, 2018
DrahtBot commented at 5:53 PM on August 31, 2018: member

No more conflicts as of last run.
laanwj commented at 9:49 AM on September 1, 2018: member

Concept ACK
jnewbery commented at 11:52 AM on September 7, 2018: member

tACK fac3e22b18cd29053bc17065fd75db7b84ba6f40
laanwj merged this on Sep 8, 2018
laanwj closed this on Sep 8, 2018
laanwj referenced this in commit cb25cd6aa1 on Sep 8, 2018
in test/functional/feature_block.py:827 in fac3e22b18
```
 823 | @@ -824,7 +824,7 @@ def run_test(self):
 824 |          tx.vin.append(CTxIn(COutPoint(b64a.vtx[1].sha256, 0)))
 825 |          b64a = self.update_block("64a", [tx])
 826 |          assert_equal(len(b64a.serialize()), MAX_BLOCK_BASE_SIZE + 8)
 827 | -        self.sync_blocks([b64a], success=False, reject_code=1, reject_reason=b'error parsing message')
 828 | +        self.sync_blocks([b64a], success=False, reject_reason='non-canonical ReadCompactSize(): iostream error')
```
ken2812221 commented at 8:57 AM on September 8, 2018:

This is non-canonical ReadCompactSize(): iostream stream error on Windows. See https://ci.appveyor.com/project/DrahtBot/bitcoin/build/master.972. Is there a way to specify the second variant? Or just discard the message to be non-canonical ReadCompactSize()

Fixed in #14007

AkioNak commented at 2:37 AM on September 13, 2018:

FYI On macOS, this is 'non-canonical ReadCompactSize(): unspecified iostream_category error'. I think #14007 will also fix this because of discarding the message to be 'non-canonical ReadCompactSize().
MarcoFalke deleted the branch on Sep 8, 2018
deadalnix referenced this in commit 31eb6eb78c on Jun 16, 2020
random-zebra referenced this in commit 2ab948e1ad on May 4, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels