tests: Reorder tests and move most of extended tests up to normal tests #14225

pull ken2812221 wants to merge 2 commits into bitcoin:master from ken2812221:2018-09-15-tests-reorder changing 2 files +15 −20
  1. ken2812221 commented at 11:25 am on September 15, 2018: contributor

    The travis should run almost all jobs unless it takes really long time, however it does not take too long for now. So it’s time for moving it to normal job.

    (The test sort is to see how many conflict will this cause, will drop it if there are too many)

    The first commit can be reviewed by git diff --color-moved=plain

  2. fanquake added the label Tests on Sep 15, 2018
  3. ken2812221 force-pushed on Sep 15, 2018
  4. DrahtBot commented at 12:44 pm on September 15, 2018: member
    • #13746 (-masterdatadir for datadir bootstrapping by kallewoof)
    • #13389 (Utils and libraries: Fix #13371 - move umask operation earlier in AppInit() by n2yen)
    • #12134 (Build previous releases and run functional tests by Sjors)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. MarcoFalke commented at 1:13 pm on September 15, 2018: member
    utACK 6e4d6ed487fcc65f551cdefc212aca329b6f70cd
  6. ken2812221 force-pushed on Sep 15, 2018
  7. ken2812221 commented at 5:29 pm on September 15, 2018: contributor
    Update: It seems impossible to run feature_pruning on travis, so I re-disable it.
  8. ken2812221 force-pushed on Sep 15, 2018
  9. tests: Reorder tests and move most of extended tests up to normal tests c0d947d725
  10. travis: Run feature_dbcrash functional tests in cron job d641c29a5a
  11. in test/functional/test_runner.py:63 in b1409f9c8f outdated
    67-    'feature_segwit.py',
    68+    'feature_fee_estimation.py',
    69     # vv Tests less than 2m vv
    70-    'wallet_basic.py',
    71-    'wallet_labels.py',
    72+    'feature_block.py',
    


    MarcoFalke commented at 6:09 pm on September 15, 2018:
    to be honest, I don’t think the reordering matters. for example, feature_block was the third test previously and is now the second test. I think it is most important to have the longest running test as the first test. The order of the remaining ones shouldn’t matter much if they are reasonably sorted by run time.

    ken2812221 commented at 4:22 am on September 16, 2018:
    You’re right. That doesn’t take a major effect. Also it seems there are a lot of merge conflicts. Now I only move them to the BASE_SCRIPTS list, not to re-order them.
  12. ken2812221 force-pushed on Sep 16, 2018
  13. conscott commented at 2:19 pm on September 16, 2018: contributor
    Tested ACK d641c29a5a7dcbf186e32af2e22cd3601e5c49fb
  14. MarcoFalke merged this on Sep 16, 2018
  15. MarcoFalke closed this on Sep 16, 2018

  16. MarcoFalke referenced this in commit 3832c25f17 on Sep 16, 2018
  17. ken2812221 deleted the branch on Sep 16, 2018
  18. Munkybooty referenced this in commit 9ec7649a7e on Jun 15, 2021
  19. Munkybooty referenced this in commit 4e26802df7 on Jun 22, 2021
  20. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-19 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me