Missing RPCAuth script in tarball #14292

1. 
   bitstein commented at 5:39 pm on September 22, 2018: contributor

   When running Bitcoin installed from a binary, the RPCAuth script found at share/rpcauth/rpcauth.py is inaccessible to the user without cloning from the repo, despite being referenced in bitcoind -help:

   0RPC server options:
   1[...]
   2  -rpcauth=<userpw>
   3       Username and hashed password for JSON-RPC connections. The field
   4       <userpw> comes in the format: <USERNAME>:<SALT>$<HASH>. A
   5       canonical python script is included in share/rpcuser. The client
   6       then connects normally using the
   7       rpcuser=<USERNAME>/rpcpassword=<PASSWORD> pair of arguments. This
   8       option can be specified multiple times
   

   v0.16.3, via tarball

   Ubuntu 18.04.1 LTS

   This could be resolved by including the script in the tarball’s share directory, so that is accessible to users. Being a small script, this would not require much overhead. Alternatively, another method could be given to allow the user to generate salted password hashes, perhaps as a command line executable.

   cc @harding

2. MarcoFalke added the label Build system on Sep 22, 2018
3. 
   MarcoFalke commented at 10:33 pm on April 26, 2020: member

   This is fixed
4. MarcoFalke closed this on Apr 26, 2020

   ---

5. 
   harding commented at 12:16 pm on May 27, 2020: contributor

   @MarcoFalke do you know which commit fixed this? The file isn’t in the 0.20 RC tarballs and I also don’t see it in the guix tarballs produced by drahtbot that involve merging with master, e.g. https://drahtbot.space/gitian/bitcoin/bitcoin/798774a521fdf73c873d4a6ece69dd38b4977a20/bitcoin-798774a521fd-x86_64-linux-gnu.tar.gz from PR 18820.
6. 
   MarcoFalke commented at 12:53 pm on May 27, 2020: member

   @harding What are the exact steps to reproduce. It works for me:

   0$ wget https://bitcoincore.org/bin/bitcoin-core-0.19.1/bitcoin-0.19.1.tar.gz
   1$ tar -xvf bitcoin-0.19.1.tar.gz 
   2$ ls bitcoin-0.19.1/share/rpcauth/rpcauth.py 
   3bitcoin-0.19.1/share/rpcauth/rpcauth.py
   4
   5$ wget https://bitcoincore.org/bin/bitcoin-core-0.20.0/test.rc2/bitcoin-0.20.0rc2.tar.gz
   6$ tar -xvf bitcoin-0.20.0rc2.tar.gz 
   7$ ls bitcoin-0.20.0rc2/share/rpcauth/rpcauth.py 
   8bitcoin-0.20.0rc2/share/rpcauth/rpcauth.py
   

7. 
   MarcoFalke commented at 12:55 pm on May 27, 2020: member

   The commit that fixed it 6674a75bfbdf680d0a3648f44c6591ff5fc983cf
8. 
   harding commented at 2:45 pm on May 27, 2020: contributor

   @MarcoFalke

   I think you’re downloading the source archive. I think this issue is about the binary distribution. Steps to reproduce:

   $ wget https://drahtbot.space/gitian/bitcoin/bitcoin/798774a521fdf73c873d4a6ece69dd38b4977a20/bitcoin-798774a521fd-x86_64-linux-gnu.tar.gz
   $ tar tzf bitcoin-798774a521fd-x86_64-linux-gnu.tar.gz | grep -i rpcauth || echo NOT FOUND
   NOT FOUND

9. 
   MarcoFalke commented at 3:18 pm on May 27, 2020: member

   It might be best to file a new issue for the missing script in the binary tarball. I always assumed this issue is about the source tarball.
10. 
    harding commented at 3:22 pm on May 27, 2020: contributor

    Ok, I’ll open a new issue.
11. DrahtBot locked this on Feb 15, 2022

Contributors
bitstein MarcoFalke harding

Labels
Build system