[wallet] Remove addwitnessaddress #14296

1. 
   jnewbery commented at 3:21 am on September 23, 2018: member

   Fully removes the addwitnessaddress RPC method, which was deprecated in V0.17
2. jnewbery renamed this:
   Remove addwitnessaddress
   [wallet] Remove addwitnessaddress
   on Sep 23, 2018
3. fanquake added the label Wallet on Sep 23, 2018
4. 
   ken2812221 commented at 10:19 am on September 23, 2018: contributor

   Concept ACK
5. [test] Fix flake8 warnings in tests

   Fix all flake8 warnings in tests that are about to be updated
   to remove addwitnessaddress

   67d7d67cf3
6. [tests] Remove deprecated addwitnessaddress call from feature_nulldummy

   addwitnessaddress is deprecated. Replace the call to addwitnessaddress
   with a call to getnewaddress(address_type='p2sh-segwit')

   bdefc9705d
7. [tests] Remove deprecated addwitnessaddress call from wallet_dump.py

   addwitnessaddress is deprecated. Remove the call to that RPC from
   wallet_dump.py and improve testing of all types of address (legacy,
   p2sh-segwit and bech32)

   3cf77f0b3e
8. [test] Remove deprecated addwitnessaddress from p2p_compactblocks.py 9d7ee187a3
9. [test] Remove deprecated addwitnessaddress from wallet_bumpfee.py 82f2fa03a5
10. [test] Remove deprecated addwitnessaddress from feature_segwit.py 07e3f585ab
11. [wallet] Remove deprecated addwitnessaddress RPC method ebec90ac97
12. jnewbery force-pushed on Sep 23, 2018
13. 
    jnewbery commented at 12:57 pm on September 23, 2018: member

    Travis was failing because of new flake8 warnings. I’ve added a new commit removing all flake8 warnings from touched tests.
14. 
    DrahtBot commented at 4:05 pm on September 23, 2018: member

    • #14534 (Enable flake8 rule E225 which checks for missing whitespace around op… by jbampton)
    • #14502 (Rpc help helper class by karel-3d)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

15. 
    DrahtBot commented at 5:35 am on September 28, 2018: member

    Coverage	Change (pull 14296)	Reference (master)
    Lines	-0.0326 %	87.0361 %
    Functions	+0.1317 %	84.1130 %
    Branches	-0.0485 %	51.5451 %

16. in doc/release-notes-14296.md:4 in 850908a679 outdated

    0@@ -0,0 +1,5 @@
    1+addwitnessaddress RPC method removed
    2+------------------------------------
    3+
    4+The `addwitnessaddress` RPC was added for segwit testing in version 0.13.1. It
    

    ---

    ---

    

    promag commented at 9:49 am on October 2, 2018:

    From doc/release-notes/release-notes-0.13.0.md

    • New RPC commands: generatetoaddress, importprunedfunds, removeprunedfunds, signmessagewithprivkey, getmempoolancestors, getmempooldescendants, getmempoolentry, createwitnessaddress, addwitnessaddress.

    ---

    

    jnewbery commented at 7:01 pm on October 17, 2018:

    fixed
17. in doc/release-notes-14296.md:5 in 850908a679 outdated

    0@@ -0,0 +1,5 @@
    1+addwitnessaddress RPC method removed
    2+------------------------------------
    3+
    4+The `addwitnessaddress` RPC was added for segwit testing in version 0.13.1. It
    5+was deprecated in version 0.17.0. This version fully removes the RPC method.
    

    ---

    ---

    

    promag commented at 9:50 am on October 2, 2018:

    From doc/release-notes/release-notes-0.16.0.md

    • The wallet RPC addwitnessaddress was deprecated and will be removed in version 0.17,

    ---

    

    jnewbery commented at 7:01 pm on October 17, 2018:

    fixed
18. 
    promag commented at 10:02 am on October 2, 2018: member

    Tested ACK 850908a, some comments though.

    nit, commit ebec90a prefix could be rpc — doesn’t touch wallet code?

19. [docs] Add release note for removing getwitnessaddress 2b91e42ece
20. jnewbery force-pushed on Oct 17, 2018
21. 
    jnewbery commented at 7:01 pm on October 17, 2018: member

    Thanks for the corrections @promag . I’ve fixed them both.
22. 
    sipa commented at 9:57 pm on October 17, 2018: member

    utACK 2b91e42ece78c3f2ae4bf12fa71f461d05426a19
23. 
    promag commented at 0:49 am on October 18, 2018: member

    Tested ACK 2b91e42, only change was fixing release notes.
24. MarcoFalke merged this on Oct 24, 2018
25. MarcoFalke closed this on Oct 24, 2018

    ---

26. MarcoFalke referenced this in commit 9dda5fdf64 on Oct 24, 2018
27. jnewbery deleted the branch on Oct 24, 2018
28. MarcoFalke locked this on Sep 8, 2021

Contributors
jnewbery ken2812221 DrahtBot promag sipa

Labels
Wallet