rpc: Add missing calls to EnsureWalletIsUnlocked #14302

pull promag wants to merge 1 commits into bitcoin:master from promag:2018-09-ensure-wallet-is-unlocked changing 1 files +4 −0
  1. promag commented at 11:12 PM on September 23, 2018: member

    No description provided.

  2. rpc: Add missing calls to EnsureWalletIsUnlocked b916cdab3d
  3. fanquake added the label Wallet on Sep 23, 2018
  4. fanquake added the label RPC/REST/ZMQ on Sep 23, 2018
  5. achow101 commented at 12:01 AM on September 24, 2018: member

    Does the wallet actually need to be unlocked for these imports to work? IIRC, the wallet only needs to be unlocked for things that involve private keys, and these don't involve private keys.

  6. promag commented at 12:08 AM on September 24, 2018: member

    You mean reading keys? Actually I should go read the code..

  7. DrahtBot commented at 12:09 AM on September 24, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:

    • #10973 (Refactor: separate wallet from node by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  8. promag commented at 12:35 AM on September 24, 2018: member

    @achow101 you are correct, sorry for the rushed PR and noise.

  9. promag closed this on Sep 24, 2018

  10. promag deleted the branch on Sep 24, 2018
  11. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me