rpc: Early call once CWallet::MarkDirty in import calls #14303

1. 
   promag commented at 11:22 pm on September 23, 2018: member

   This gives a small, but not relevant, performance improvement when calling importmulti RPC since MarkDirty is called only once.

   Note that ImportScript is not atomic: https://github.com/bitcoin/bitcoin/blob/920c090f63f4990bf0f3b3d1a6d3d8a8bcd14ba0/src/wallet/rpcdump.cpp#L227-L242 ie something can fail after a successful AddWatchOnly, which could lead to invalid cached balances. That’s why the MarkDirty call is done as early as possible.

2. fanquake added the label Wallet on Sep 23, 2018
3. fanquake added the label RPC/REST/ZMQ on Sep 23, 2018
4. 
   DrahtBot commented at 0:08 am on September 24, 2018: member

   • #14565 (Overhaul importmulti logic by sipa)
   • #14454 (Add SegWit support to importmulti by MeshCollider)
   • #13787 (Test for Windows encoding issue by ken2812221)
   • #9381 (Remove CWalletTx merging logic from AddToWallet by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. promag force-pushed on Sep 24, 2018
6. 
   DrahtBot commented at 5:17 am on September 28, 2018: member

   Coverage	Change (pull 14303)	Reference (master)
   Lines	+0.0339 %	87.0361 %
   Functions	+0.1390 %	84.1130 %
   Branches	+0.0039 %	51.5451 %

7. 
   meshcollider commented at 8:52 am on October 8, 2018: contributor

   Concept ACK
8. 
   achow101 commented at 1:10 am on October 9, 2018: member

   utACK 0a1bbf739890408c44dafd96f6643d86d54c2537
9. 
   meshcollider commented at 10:51 pm on October 18, 2018: contributor

   utACK https://github.com/bitcoin/bitcoin/pull/14303/commits/0a1bbf739890408c44dafd96f6643d86d54c2537 Needs rebase
10. meshcollider added the label Refactoring on Oct 18, 2018
11. DrahtBot added the label Needs rebase on Oct 20, 2018
12. rpc: Early call once CWallet::MarkDirty in import calls 93196eeacc
13. wallet: Refactor CWallet::MarkDirty to EXCLUSIVE_LOCKS_REQUIRED(cs_wallet) 852f295ea6
14. promag force-pushed on Oct 20, 2018
15. 
    promag commented at 10:05 am on October 20, 2018: member

    Rebased.
16. DrahtBot removed the label Needs rebase on Oct 20, 2018
17. DrahtBot added the label Needs rebase on Oct 31, 2018
18. 
    DrahtBot commented at 5:02 pm on October 31, 2018: member
19. promag closed this on Oct 31, 2018

    ---

20. laanwj removed the label Needs rebase on Oct 24, 2019
21. MarcoFalke locked this on Dec 16, 2021

Contributors
promag DrahtBot meshcollider achow101

Labels
Refactoring Wallet RPC/REST/ZMQ