Trivial: update comment in CheckTransaction #14247 #14317

pull brouwerQ wants to merge 1 commits into bitcoin:master from brouwerQ:brouwerQ-patch-1 changing 1 files +1 −0

brouwerQ commented at 9:43 AM on September 25, 2018: none

No description provided.
Trivial: update comment in CheckTransaction #14247 1afb577c9a
fanquake added the label Docs on Sep 25, 2018
instagibbs commented at 3:06 PM on September 27, 2018: member

related: #14257

But it looks like the "subsuming" PR was closed too?
DrahtBot commented at 4:08 AM on September 28, 2018: member



Coverage Change (pull 14317) Reference (master)

Lines +0.0331 % 87.0361 %

Functions +0.1235 % 84.1130 %

Branches +0.0095 % 51.5451 %

Coverage	Change (pull 14317)	Reference (master)
Lines	+0.0331 %	87.0361 %
Functions	+0.1235 %	84.1130 %
Branches	+0.0095 %	51.5451 %

in src/consensus/tx_verify.cpp:184 in 1afb577c9a

 180 | @@ -181,6 +181,7 @@ bool CheckTransaction(const CTransaction& tx, CValidationState &state, bool fChe
 181 |      }
 182 |  
 183 |      // Check for duplicate inputs - note that this check is slow so we skip it in CheckBlock
 184 | +    // UPDATE: not skipped anymore in CheckBlock due to fix for crash bug with duplicate inputs within a transaction (#14247)

promag commented at 10:14 AM on October 2, 2018:

Instead of adding more comments, the comment above should be fixed?

promag commented at 10:19 AM on October 2, 2018: member

Should follow same rationale as #14258 (comment)
MarcoFalke closed this on Oct 4, 2018
DrahtBot commented at 9:10 AM on October 4, 2018: member
Reviewers, this pull request conflicts with the following ones:
- #14387 (Faster Input Deduplication Algorithm by JeremyRubin)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels