Immature balance does not update correctly #1432

I noticed that the new 'Immature balance' label is not updated correctly when they actually mature. In fact, also the normal 'balance' label is not updated correctly.

Observed behavior:

1. When starting bitcoin-qt all is well: The mined transactions below 120 confirmations are added and listed 'immature', the rest of the transactions are added and listed under 'balance'.
2. When a block is received in which new coins are mined they are added to the 'immature balance'. So far so good.
3. When a block is received pushing the number of confirmations of a mined transaction above 120, this transaction's icon is changed to a green V, but its value is not deducted from the immature balance, and it is also not added to the regular balance. The only way to have it display correctly is to restart bitcoin-qt, as then one goes to situation 1) again.

Desired behavior: The labels should reflect the correct balance/immature balance at all times, according to the currently downloaded and verified (and matured) blocks.

I can confirm this behaviour.

#837 was the pull who introduced the Immature balance display.

I have a patch ready for this, but I'm not entirely sure about it. Perhaps another dev can take a look at it first! https://github.com/Diapolo/bitcoin/commit/04e75e4ab9e426b4b0c4e59196dbe5be127ad497

I'm sure the current call to GetCredit(pcoin) can't be correct, as it does:

<pre> if (IsCoinBase() && GetBlocksToMaturity() > 0) return 0; </pre>

And this is the opposite of what we need for the immature coins, right?

I found out (via a matured amount of BTC), that the displayed balance is not updated correctly (after a client-restart the value is correct though), so I now added an update of the displayed balances on a changed block number.

https://github.com/Diapolo/bitcoin/tree/GUI_fix_immature

Can any developer comment if that makes sense for Bitcoin-Qt? When an immature balance matures, this involves just a changed block count and not a new transaction, right?

I seem to have a somehow related problem with official 0.6.3.RC1, which doesn't show unconfirmed balances, although I have a transacion that indeed should be added to unconfirmed balance. Can anyone confirm this?

@laanwj How is progress going for your fix to this issue? Would be a bad thing if this get's into 0.7 IMHO.

I don't have much time to work on this at the moment.

I took a look, but when reaching the boost::signal stuff I was out ;). Too bad...

You don't have to do anything with the boost::signal stuff.

The only thing that is needed is a function like TransactionTableModel::updateConfirmations, called by a timer, in WalletModel, except that instead of the number of confirmations it recomputes the balances if the number of blocks changed.

Only a few lines of code, really, I may get around to this in the weekend.

Reference to #1559.

This should be fixed and can be closed now!