qt: Correct misleading "overridden options" label #14375

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20181002-gui-overridden-options changing 1 files +1 −1

hebasto commented at 9:36 PM on October 2, 2018: member

Refs: #3867, #8165.
fanquake added the label GUI on Oct 2, 2018
DrahtBot commented at 6:21 AM on October 4, 2018: member



Coverage Change (pull 14375) Reference (master)

Lines +0.0177 % 87.0471 %

Functions +0.1081 % 84.1130 %

Branches +0.0142 % 51.5403 %
Sjors approved
Sjors commented at 4:26 AM on October 5, 2018: member

Much better text imo.

utACK cddc166ceac284e71522d973733a12b2803218a8

FYI #12833 would completely eliminate the need for this message.
DrahtBot commented at 6:41 PM on November 13, 2018: member



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.

Coverage	Change (pull 14375)	Reference (master)
Lines	+0.0177 %	87.0471 %
Functions	+0.1081 %	84.1130 %
Branches	+0.0142 %	51.5403 %

Correct misleading "overridden options" label

Command-line options override values set in the configuration file and
configuration file options override values set in the GUI.

7514361254

in src/qt/forms/optionsdialog.ui:717 in cddc166cea outdated
```
 713 | @@ -714,7 +714,7 @@
 714 |          <item>
 715 |           <widget class="QLabel" name="overriddenByCommandLineInfoLabel">
 716 |            <property name="text">
 717 | -           <string>Active command-line options that override above options:</string>
 718 | +           <string>GUI options overridden by the command line or in the configuration file:</string>
```
laanwj commented at 7:08 AM on November 23, 2018:

I think the first part is confusing, these are not only GUI options, but anything that can be configured in the options dialog.

hebasto commented at 7:19 AM on November 23, 2018:

Could it be: "Options set in this dialog and overridden by the command line or in the configuration file:" ?

laanwj commented at 12:06 PM on November 23, 2018:

yes, that's better
hebasto force-pushed on Nov 23, 2018
hebasto commented at 1:44 PM on November 23, 2018: member

@laanwj Thank you for your review. Your comment has been addressed. Would you mind re-reviewing?
laanwj commented at 3:11 PM on January 3, 2019: member

utACK 75143612546450c064ccd8dcf1f7f6e79f397802
laanwj merged this on Jan 3, 2019
laanwj closed this on Jan 3, 2019
laanwj referenced this in commit d1effa11ad on Jan 3, 2019
hebasto deleted the branch on Jan 3, 2019
jasonbcox referenced this in commit 82ded1d004 on Oct 26, 2020
PastaPastaPasta referenced this in commit adb254d37e on Jun 26, 2021
PastaPastaPasta referenced this in commit ac3fb0372c on Jun 28, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#3867 qt: Show also value for options overridden on command line #8165 Improvement: Show active command line options / parameters values in GUI

qt: Correct misleading "overridden options" label #14375

Conflicts