Bit #14412

ghost commented at 5:56 AM on October 6, 2018: none

Pull requests without a rationale and clear improvement may be closed immediately.

Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly.

Any test improvements or new tests that improve coverage are always welcome.
All other changes should have accompanying unit tests (see src/test/) or functional tests (see test/). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change.
Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed.
Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible.
Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they significantly improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the developer notes, stylistic code changes are usually rejected.

Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time.

Reorganize includes a bit. 8995f8ed61

Fix V595 PVS Studio - the pointer was utilized before it was verified against nullptr. 87f1882c68

Experimental support for TX_PUBKEY_DROP spending. 661cd826c1

Remove asserts. a5f0a4f9ea

Same as @92e04fc 4703e1af35

ListMalleablePubKeys method febcfc9c05

Merge pull request #272 from svost/V668

Fix V668 PVS Studio - deal with pointer and NULL

05dcb40ecb

Merge pull request #273 from svost/includes

Reorganize includes a bit.

2fa437d0d0

Merge pull request #274 from svost/patch

Fix V595 PVS Studio - the pointer was utilized before it was verified…

0b47046733

RPC: Add new methods suitable for malleable key pairs management;

Save generated key pairs in the wallet.dat.

Due to lack of time for a proper debugging the generation of malleable keys has been disabled on the main network. Of course it will be enabled in the near future.

132c462454

Merge branch 'master' of ssh://github.com/novacoin-project/novacoin 0e14c940ba

fDetachDB missed in constructor 213f208b2c

Fix compilation error. f87679bb07

RPC: encryptdata & decryptdata methods d8f174b14a

Performance: replace iterator++ with ++iterator

Оставлю как якорь, подобных мест в коде много, по возможности можно будет переписать.

16f94b8c51

Examples and missed file. 9c8de278b4

Merge pull request #275 from svost/patch

fDetachDB missed in constructor

379ba3caf0

Header guard added a267c7697f

Merge pull request #276 from svost/patch

Minor fix

4bbf843059

Comparison fix a61b9f488d

Fix gcc Wreorder warning 9d7059e6d6

Add copy constructor to prevent undefined behaviour. 84dbd33baf

Move the constant variable outside the loop c12fd552e3

Remove namespaces from header files 5e82f02b59

Format fix: %p prefer void*

Как пример
https://gcc.gnu.org/viewcvs/gcc/trunk/gcc/config/iq2000/iq2000.c?r1=192717&r2=192716&pathrev=192717

5bb062c5a6

rpccrypt.cpp: Add message encryption and decryption methods. fa743e433b

Merge pull request #277 from svost/patch

Minor fix

e892054558

Merge pull request #278 from svost/headers

Remove namespaces from header files

18719a4615

Removed dependency (boost::algorithm::starts_with) 455f59ba9a

Wallet core: remove SendMoneyToDestination fb1e78e0e8

RPC: Modify sendtoaddress/sendfrom methods to treat public key pair as a variant of novacoin address. 2d834e1bd2

Raw transactions: TX_PUBKEY_DROP parsing 50b8ba09b7

Don't inbclude listen port and testnet option into autogenerated config file. d420f6281c

Allow PUBKEY_DROP inputs on testnet 01983570a6

TX_PUBKEY_DROP fix a38a9762f2

A proper initialization of nReqSigs. f2c5d911d3

getrawtransaction: Support for malleable public keys 1fb1a79af0

Merge branch 'master' of github.com:novacoin-project/novacoin 0bf6a81d74

ScriptPubKeyToJSON: include matched key view. eecfdfba2e

Merge pull request #279 from svost/patch

Minor fix

7b30fc99cf

Get rid of some LONG variables 572dd6fda7

gettransaction: use pubkey pair instead of key view. 3d5401d7f0

Merge branch 'master' of github.com:novacoin-project/novacoin cac9353f3e

Use largest finite value for MAX_MONEY 885c94832a

Fix V808 PVS Studio: object created but was not utilized a1ecd31c23

netbase: Use .data() instead of .c_str() on binary string

`.c_str()` is only guaranteed to return the data up to the first NUL
character.

0a3c2f66e9

Remove LookupHostNumeric( ) which is never used 40d7e72060

openssl: avoid config file load/race (see bitcoin d4b1d5a) 0d6fb4761b

Add OP_CHECKLOCKTIMEVERIFY support. e1ebe9e91b

Simplify OP_RETURN handling. 96b34e50e8

Merge pull request #280 from svost/patch

Minor fix

b67a0d7967

Merge pull request #281 from FuzzyHobbit/patch-6

Use largest finite value for MAX_MONEY

42696f28d7

Merge pull request #282 from svost/from-bitcoin

From bitcoin

13fb9d6960

Integer tempalte matching opcode. 49db62f894

OP_CHECKSEQUENCEVERIFY f8f873db4b

Well, I'd say that indents aren't needed here. 7a0b1a6c2a

Allow generation of keypairs for mainNet clients since 20 March, 2016 f4507055f2

Update README.md 2f2bcf880c

Don't compare oranges to apples. 3497f0f22d

Remove c_str: stringvar1 = stringvar2 ed42780b91

Add -splitthreshold option

https://bitcointalk.org/index.php?topic=704756.msg13890630#msg13890630

194fca886d

Merge branch 'master' of github.com:novacoin-project/novacoin 294fd35276

Merge pull request #283 from svost/patch

Minor fix

e8c66fbba7

Remove COINBASE_SIGOPS_SWITCH_TIME 3886cd3bee

Remove BIP0031_VERSION and MEMPOOL_GD_VERSION. 3e7d898850

Bump CLIENT_VERSION_BUILD 7653c7370e

Do some cleanup, add importmalleablekey RPC call fd84b67ead

MSVC solution update 6d5a91c80b

Separate implementations of CHECKLOCKTIMEVERIFY and CHECKSEQUENCEVERIFY. db0fbd2d3a

Disable OP_CHECKSEQUENCEVERIFY for now, since the BIP68 is not implemented. 5843fbb222

Merge pull request #284 from svost/solution

MSVC solution update

54690ebcde

Fix msvc c4800: explicit cast to bool 101094563e

FormatMoney cleanup b50bcafff5

Move transaction timestamp checking to CTxMemPool::accept() 1d7a5b0866

Force one week max offset for testNet. 10d86b0a12

Not utilized d20116c8fa

Experimental: use Solver to find out all solutions for txout.scriptPublicKey 4334f0854a

Remove testnet condition c5dbcadfa0

Add CWallet::ExtractAddress method 331e3c9864

Introduce nOneWeek constant 5c3da961f2

Since the buffer is constant, we set the length directly c7f60eb71d

Update script.h

* Fix MSVC C4245: signed/unsigned mismatch
* Commented out SEQUENCE_THRESHOLD: never used
* C++ style comments

07795bdb37

Store only the second half of private key pair. 7dd7fb48b1

Check for NULL values properly. 75e0e72d8c

Add DEBUG option 766371edb6

Encryption/decryption support for malleable keys. 75d1689816

Merge branch 'patch' of ssh://github.com/svost/novacoin into svost-patch 17026a81cb

Merge branch 'svost-patch' 72ded6ae92

Malleable keys: remove version byte ecc21b2723

Simplified macro 81e9e33e6b

Useless pragma 2058eaa4ce

Merge pull request #286 from svost/patch

Patch

56c09fb0ce

Add hex representation 025e8938ee

PUBKEY_PAIR_ADDRESS / PUBKEY_PAIR_ADDRESS_TEST 7cacf505fc

Cleanup c04f979c80

Don't throw exceptions while processing public values. a37aeb3dd4

Get rid of boost::split function 75ec6d7e0b

Simplification of scriptPubKey handling code. 3eedd3abbd

Use CBitcoinAddress ti store change destination 425455bb33

Merge pull request #287 from svost/patch

Minor fix

17237eaed7

It's senseless to import pubkey pair address. 5842a4a143

Merge branch 'master' of github.com:novacoin-project/novacoin 0b40e91922

COunt received coins for owned pubkey-pair addresses properly 12f1208c42

New dump function.

TODO: pubkey pair addresses import.

d3f6c99eb1

DumpWallet() cleanup 08ab3b7792

c_str() isn't needed here 233f0f2c68

ResendTX: forced rebroadcasting of unconfirmed transactions. ce44287044

ImportWallet() : process private key pairs fe67404738

Ies_ctx_t - move to try catch block 0467c286a9

Code style fix (no "tab" symbol). 7e553ad006

Keep address labels for pubkey pair addresses. d0533f11f1

Fix daemon compilation isue. de495eadd0

Automatically add empty label for pubkey pair addresses. 21a158ae52

Update for 85088c5 8f8b8543b8

List of unconditionally banned blocks.

Unlike with checkpoints, block height doesn't matter here.

61894db635

Revert "openssl: avoid config file load/race (see bitcoin d4b1d5a)"

This reverts commit a303a6ee32ebc04eb261db780f1e968f58d6e260.

This feature was made deprecated ages ago.

81b151b696

New version of OpenSSL 5bad5c79d6

Merge pull request #288 from svost/patch

Patch

0c9d9eadd8

Fix compilation warnings. a281267a9d

Use current CC and CXX environment variables for leveldb compilation. 982d13875e

ECIES: Replace SHA1 with RIPEMD-160. fe41e33bdf

Remove unused includes. bde368e9dd

RPC: decryptmessage documentation fix c968932981

Fix msvc c6262 warning: excessive stack usage f248e7c93a

Switch nSize to size_t

Based on:
EC_POINT_point2oct return size_t
void resize (size_type n, value_type val = value_type());

5c3b37dc26

Fix msvc warning C4706: assignment within conditional expression 3a67fa7907

Merge pull request #289 from svost/patch

Patch

e3a906a0b9

Fix msvc warning C4706: assignment within conditional expression 27433b3702

Version: compiler name suffix update af6238566c

Fix msvc c4127 warning a23a71eaf5

Merge pull request #290 from svost/patch

Minor fix

b4185e4f7c

Fix msvc c4127 warning de656fc87c

Initializing: type mismatch 5fc478219a

Merge pull request #291 from svost/patch

Minor fix

2a6d1dcc77

Checkpoint fa8a69c1fc

Bump client version 30d7d109c9

Switch from boost types to <stdint.h>

see 6cea4ed
grep -rn '::uint64_t' * && grep -rn '::int64_t' *

5ad982d70e

Fix set of msvc C4127 warning ea1c500f6f

Merge pull request #292 from svost/patch

Minor fix

c1aacb3c27

There is no need for these conditions anymore. c55924cc1a

Merge branch 'master' of github.com:novacoin-project/novacoin cce6abf46d

HTTP seeding script e6eea8ea30

Exception handling, implement norpc option dece05facd

EXPERIMENTAL: custom peer collector

You can specify a custom peer collector using syntax like -peercollector=<cmd>. Sample collector can be found in the contriob/seeds/getseeds.py file.

95df972190

Fix 0600cb7efd

MSVC project update 85193098d5

=> Python3 b92308f3b3

Fix 7d83156596

Create setup.py for getseeds script. d72572136a

Do not print sensitive data 2a0c53d481

http://stackoverflow.com/questions/12505383/print-not-working-when-compiled-with-py2exe 78b1e58377

Network options: External seeder option 6584e58072

QT5 fix b7ea7c2f16

Trying to proccess .app references correctly 5da8fc5521

lupdate 9d2db684c1

Bump version to 0.5.7 8163cc7f13

Minor optimization 6db326c707

Fix type mismatch 6198cc3705

Main.cpp: fix type mismatch cb243bbc0d

Remove BOOST_FOREACH macro e8bc2c6b02

Partially revert acd906f9bbf55e42. 8ef54c4d84

QREncode linking fix 5471fad9ab

Merge pull request #293 from svost/patch

Minor fix

261ecdea9f

Reorg includes: fix MSVC buid 22c0389192

Merge pull request #294 from svost/patch

Minor fix

34a89de9ae

It's a c++: use string.empty() f46bc1d943

It's a c++: use string.clear() be13939cfc

Get rid of ARRAYLEN macro bef52f22f3

Merge pull request #295 from svost/patch

Minor fix

1e938f1864

Move signature verification functions to CPubKey. 08b12b836c

Merge branch 'master' of github.com:novacoin-project/novacoin 0b247f10b7

Remove senseless comparison. 6c21456952

Fix type error 1d20251422

EC_EVP_KEY_free() causes memory corruption in libnssl. ca3d012169

Private key is self-sufficient. ee8c46fce3

Remove print() methods: all unused b0082ffd7c

Get rid of 'e': all unused e659f8d190

Stochastic broadcasting delay. dc68eda246

Use nOneDay c8d39b2602

Fix pointer to local variable logic (V506 PVS Studio) 56c1d14225

Get rid of fTrickle parameter 1023e3e9be

Remove unused function. 3f9387d458

Merge pull request #296 from svost/patch

Minor fix

a4bd291267

Get rid of fTrickle parameter. 1ecb2db255

Merge branch 'master' of github.com:novacoin-project/novacoin e1d33d5e29

Revert 2d6690cc0c0e2525996856c392566133d1b2de50 8e5adbbb79

Split CMerkleTx::SetMerkleBranch 180163e0e7

Remove unused argument. 78bf82fd1e

Move some implementations of CWallet methods to wallet.cpp. 9869e09943

Move some implementations of CWallet methods to wallet.cpp. 98e0cb3b06

RPC: Replace resendtx with resendwallettransactions. 28dd1046a2

RPC: In addition to public key pairs, adjustmalleablepubkey method now understands malleable addresses and key views. ff2771c19c

Remove BOOST_FOREACH macro 172d8aee9b

Rewrite pszTimestamp var: get rid of char* ada534e074

Merge pull request #297 from svost/patch

Minor fix

2889514fe2

Our internal state doesn't matter. 7312b1bf5b

Preserve key compression attribute while initializing a new instance of CKey.

THis bug was originally reported by Alex AXe: https://bitcointalk.org/index.php?topic=704756.msg14401298#msg14401298

fca2d82929

Get rid of fCompressedPubKey attribute. 66a1164b7c

Bump version to 0.5.8

Uncompressed public keys issue has been fixed.

d1bec999dd

Fix importprivkey issues.

1) Handle parameters correctly;
2) Create label entry for a newly imported private key.

7f2362e257

Merge branch 'master' of github.com:novacoin-project/novacoin 8d035aaa5c

RPC: now decryptdata/decryptmessage methods are able to understand WIF formatted private key. b30efd5b1a

Revert "Split CMerkleTx::SetMerkleBranch"

This reverts commit 40530c08006088e6f610063f1c49428aa0b272f6.

e0cafea1f9

From boost(std)::thread::hardware_concurrency description: if this value is not computable or well defined, the function returns 0. 5e071d911a

Merge pull request #300 from svost/patch

Minor fix

ff580cdadc

Get rid of boost::counting_iterator 1037656018

Merge pull request #302 from svost/patch

Minor fix

bbc17a7101

DNSNode: fix source name c052a8c99f

Update seed nodes array. 2a20c10c81

Merge pull request #310 from svost/master

Address fix

4a26859c4f

Fix memory leak. fee71e11ac

CPubKey::Verify() : Fix memory leak. 2bd96badf2

We have not yet implemented begin() and size() methods in the master branch. 405d62b358

Fix listaddressgroupings comand 184b75381d

Merge pull request #351 from svost/patch

Fix listaddressgroupings comand

b6f4727f60

42-coin "New Chain" Release

The Answer to Life, the Universe, and Everything...

4dd28f80df

Add checkpoint @ block # 4200 ef2c2dd2e0

Add cryptoid.info block explorer URL 6d1600c57a

Update icons for Debian 31ee1d46e1

Copyright Info Update 20604445eb

Update MacOS icons 92af4781f4

Fix C++11 compatibility issue 909973026b

42-qt.pro: Change the link for macxBDB_LIB_PATH a531a3a409

Clarify a license of the main logo 6366236c6d

Clear history when using clear button in RPC console b05c30f3d1

Upd. an example in the second auth. dialog 8c823f2c80

Increase max offset time for the MedianTimePast 94f1854a4e

Make max PoS age unlimited 29d82edd76

Update debian/copyright c12a04b74a

RPC: fix "Invalid 42 address" error

https://bitcointalk.org/index.php?topic=1502028.msg18565832#msg18565832

64af179d85

Update doc: building 42d and 42-qt under Windows with MinGW 70f0043d2f

Add checkpoint @ block # 21000 7c38b3bbfc

Bump version to 0.0.8 27ba8a4da3

Update doc: crosscompiling & osx building manuals 4344daeb6d

Add prohashing.com block explorer URL 0466ddb653

Fix version info and build time 57514c7e0b

Add checkpoint @ block # 42000 e7c373aeb7

Fix CBitcoinAddressGetKeyID logic

Fix gcc 7.0 warning (Wimplicit-fallthrough)

674830b177

Fix 42 logo d02af84b9a

Upd README.md e3f37994cb

Fix MintProbability column f97ec4e154

Add checkpoint @ block # 70000 cd840983d0

Update Copyright Year 3fdcf6e771

Fix logo link 27522f01c2

Upd README.md 17a13496c5

Fix wallettools/ .py 42 RPC Port c738dc89f0

Upd. translation e8c850c5d8

Add checkpoint @ block # 84000 f8864e0cb1

Bump version to 0.0.9 07688e7293

Update ntp servers list 8ff3861cdf

fanquake closed this on Oct 6, 2018

MarcoFalke locked this on Sep 8, 2021