Cross-platform “Open debug logfile” #1444

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2012_06_opendebuglog changing 2 files +2 −10

laanwj commented at 2:39 PM on June 12, 2012: member

The option to open the debug logfile from the debug window was implemented only for windows. By using QDesktopServices::openUrl it now works on any platform.

Cross-platform "Open debug logfile"

The option to open the debug logfile from the debug window was implemented only for
windows. By using `QDesktopServices::openUrl` it now works on any platform.

9b1732baae

in src/qt/guiutil.cpp:None in 9b1732baae

 245 | +    /* Open debug.log with the associated application */
 246 |      if (boost::filesystem::exists(pathDebug))
 247 | -        /* Open debug.log with the associated application */
 248 | -        ShellExecuteA((HWND)0, (LPCSTR)"open", (LPCSTR)pathDebug.string().c_str(), NULL, NULL, SW_SHOWNORMAL);
 249 | -#endif
 250 | +        QDesktopServices::openUrl(QUrl::fromLocalFile(QString::fromStdString(pathDebug.string())));

Diapolo commented at 3:09 PM on June 12, 2012:

No further include is needed for this?

Diapolo commented at 3:12 PM on June 12, 2012: none

Tried it and works, ACK!
laanwj referenced this in commit c4879a0c2f on Jun 13, 2012
laanwj merged this on Jun 13, 2012
laanwj closed this on Jun 13, 2012
coblee referenced this in commit b3baf61911 on Jul 17, 2012
laanwj deleted the branch on Apr 9, 2014
lateminer referenced this in commit 01a002bc28 on Jan 22, 2019
lateminer referenced this in commit 6879786153 on May 6, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

laanwj

Diapolo