qt: Fix QCompleter popup regression #14450

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20181009-console-autocomplete changing 1 files +1 −0

hebasto commented at 9:01 PM on October 9, 2018: member
The PR #8129 has introduced a regression with the QCompleter popup in the Debug window.

How to reproduce:
1. open the Debug window;
2. go to the 'Console' tab;
3. start writing some RPC command and try to pick it from the list using arrow keys, press Enter.
Note that the popup used to display completions is not being closed. To close it they should mouse click somewhere outside of the popup.

The wrong behaviour of the QCompleter popup is observed on Linux Mint 19 and Windows 10. This PR fixes this regression.

Refs:
- #7613
- #7772
- #8129
fanquake added the label GUI on Oct 9, 2018
promag commented at 9:57 PM on October 9, 2018: member

Tested ACK b7df768 on Windows 10.
hebasto commented at 2:20 PM on October 12, 2018: member

@Sjors Would you mind to review this PR?
Sjors commented at 6:36 AM on October 13, 2018: member

Tested b7df768 on macOS 10.14 and 5.11.2. It fixes the bug, but introduces a new one: commands get duplicated. <img width="296" alt="schermafbeelding 2018-10-13 om 15 36 06" src="https://user-images.githubusercontent.com/10217/46902291-b8f65800-cefd-11e8-93a9-2efbe29c3438.png">

Fix QCompleter popup regression

The PR #8129 has introduced a regression with the QCompleter popup in
the Debug window.

How to reproduce:
  1) open the Debug window;
  2) go to the 'Console' tab;
  3) start writing some rpc command and try to pick it from the list
using arrow keys, press Enter.
Note that the popup used to display completions is not being closed. To
close it they should mouse click somewhere outside of the popup.

081cc02a98

hebasto force-pushed on Oct 13, 2018
hebasto commented at 11:22 AM on October 13, 2018: member

@Sjors Thank you for your review. Fixed. Please re-review.
Sjors commented at 2:49 AM on October 14, 2018: member

tACK 081cc02 for macOS 10.14 / QT 5.11.2. Needs retesting on Windows.
hebasto commented at 4:49 PM on October 16, 2018: member

@promag Would you mind re-reviewing this PR?
jonasschnelli commented at 6:22 PM on October 17, 2018: contributor

Tested ACK 081cc02a9815318d5197a9a1db7e582bfa23ea51
jonasschnelli merged this on Oct 17, 2018
jonasschnelli closed this on Oct 17, 2018
jonasschnelli referenced this in commit 816fab9cca on Oct 17, 2018
hebasto deleted the branch on Oct 18, 2018
PastaPastaPasta referenced this in commit a2854053ae on Jun 27, 2021
PastaPastaPasta referenced this in commit 6538104447 on Jun 28, 2021
PastaPastaPasta referenced this in commit b8ecf6b466 on Jun 29, 2021
PastaPastaPasta referenced this in commit e584c6f24c on Jul 1, 2021
PastaPastaPasta referenced this in commit e202bda4e6 on Jul 1, 2021
PastaPastaPasta referenced this in commit e14cda2d6a on Jul 1, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7613 Add autocomplete to bitcoin-qt's console window.#7772 Clear the input line after activating autocomplete #8129 Fix RPC console auto completer