test: forward timeouts properly in send_blocks_and_test #14456

pull jamesob wants to merge 1 commits into bitcoin:master from jamesob:2018-10-test-forward-timeouts changing 1 files +2 −2
  1. jamesob commented at 6:54 AM on October 10, 2018: member

    Small change motivated by frustrations while writing feature_block tests; when a timeout is passed to send_blocks_and_test it isn't forwarded onto constituent waiting calls - you can end up waiting 60 seconds when you articulated e.g. 5. Respect the given timeout all the way down.

  2. test: forward timeouts properly in send_blocks_and_test 94e21c1501
  3. fanquake added the label Tests on Oct 10, 2018
  4. DocOBITCOIN approved
  5. conscott commented at 3:32 PM on October 11, 2018: contributor

    Tested ACK 94e21c1501660e16d6d6bff94265bf910102b8a1

    I suppose you could also add similiar logic to send_txs_and_test to make it uniform

  6. sipa commented at 8:02 PM on October 12, 2018: member

    utACK

  7. fanquake requested review from MarcoFalke on Oct 20, 2018
  8. MarcoFalke merged this on Oct 20, 2018
  9. MarcoFalke closed this on Oct 20, 2018

  10. MarcoFalke referenced this in commit d433239a8d on Oct 20, 2018
  11. deadalnix referenced this in commit 18d9600f4e on Apr 24, 2020
  12. ftrader referenced this in commit 2ba86745f1 on Aug 17, 2020
  13. random-zebra referenced this in commit bffe509aed on Jun 28, 2021
  14. Munkybooty referenced this in commit ba21c827c9 on Jul 21, 2021
  15. MarcoFalke locked this on Sep 8, 2021


MarcoFalke

Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-27 21:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me