tests: Stop node before removing the notification file #14465

1. 
   ken2812221 commented at 10:06 pm on October 11, 2018: contributor

   Stop node before removing the notification file to make sure the command has been terminated. After then we could removing those files safely and do not receive any permission error. (See #14446)

   The permission error is Windows specific, documented in python doc:

   On Windows, attempting to remove a file that is in use causes an exception to be raised

   See https://docs.python.org/3/library/os.html#os.remove

2. tests: Stop node before removing the notification file ca6d86c322
3. 
   promag commented at 10:13 pm on October 11, 2018: member

   ACK. Have you checked for other cases?
4. 
   ken2812221 commented at 10:29 pm on October 11, 2018: contributor

   Have you checked for other cases?

   Yes, but still in investigation.

5. 
   meshcollider commented at 11:53 pm on October 11, 2018: contributor

   LGTM, utACK https://github.com/bitcoin/bitcoin/commit/ca6d86c3221fbeab63f451e1fb901a68d2c4a1aa
6. fanquake added the label Tests on Oct 12, 2018
7. 
   sipa commented at 7:40 pm on October 12, 2018: member

   utACK
8. 
   conscott commented at 2:36 pm on October 15, 2018: contributor

   Possible other case in the mempool persist test ? Although in this case, removing an active file is intentional.
9. fanquake requested review from MarcoFalke on Oct 18, 2018
10. sipa merged this on Oct 19, 2018
11. sipa closed this on Oct 19, 2018

    ---

12. sipa referenced this in commit d387507aec on Oct 19, 2018
13. ken2812221 deleted the branch on Oct 19, 2018
14. jasonbcox referenced this in commit 0d733b66aa on Jul 30, 2020
15. 5tefan referenced this in commit f9cd7ffa58 on Aug 13, 2021
16. 5tefan referenced this in commit d09b13066c on Aug 14, 2021
17. PastaPastaPasta referenced this in commit f370f41210 on Aug 16, 2021
18. DrahtBot locked this on Sep 8, 2021

Contributors
ken2812221 promag meshcollider sipa conscott

Review Requested
MarcoFalke

Labels
Tests