Pin flake8 version to earlier version to avoid pyflakes update #14563

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:fix_flake changing 1 files +1 −1

instagibbs commented at 8:55 PM on October 24, 2018: member

pyflakes dep was ratcheted to 2.0 which seems to have broken a lot of the lint checking: https://gitlab.com/pycqa/flake8/commit/527af5c214ef0eccfde3dd58d7ea15e09c483bd3

Also could use a backport to 0.17.
Pin flake8 version to earlier version to avoid pyflakes update 6fbbad2e1f
promag commented at 9:25 PM on October 24, 2018: member

Hmm this was done in #14496 (?)
instagibbs closed this on Oct 24, 2018
instagibbs commented at 9:34 PM on October 24, 2018: member

@promag Huh. Ok I'll just see if we can get a fix backported to 0.17.
promag commented at 9:37 PM on October 24, 2018: member

It's weird how github showed the diff.
instagibbs commented at 9:41 PM on October 24, 2018: member

Yeah. Thanks for saving me time!

On Wed, Oct 24, 2018, 5:38 PM João Barbosa notifications@github.com wrote:

It's weird how github showed the diff.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/14563#issuecomment-432837247, or mute the thread https://github.com/notifications/unsubscribe-auth/AFgC02NTB2TCEOBdlVAMZkXtusX0zrjYks5uoN3tgaJpZM4X5Azb .
MarcoFalke locked this on Sep 8, 2021

Contributors