Introduce -tracenet option, thereby quieting some redundant debug messages #1458

pull jgarzik wants to merge 1 commits into bitcoin:master from jgarzik:tracenet changing 5 files +13 −2

jgarzik commented at 2:41 AM on June 14, 2012: contributor

Prior to this change, each TX typically generated 3+ debug messages,

askfor tx 8644cc97480ba1537214   0
sending getdata: tx 8644cc97480ba1537214
askfor tx 8644cc97480ba1537214   1339640761000000
askfor tx 8644cc97480ba1537214   1339640881000000
CTxMemPool::accept() : accepted 8644cc9748 (poolsz 6857)

After this change, there is only one message for each valid TX received

CTxMemPool::accept() : accepted 22a73c5d8c (poolsz 42)

and two messages for each orphan tx received

ERROR: FetchInputs() : 673dc195aa mempool Tx prev not found 1e439346fc
stored orphan tx 673dc195aa (mapsz 19)

The -tracenet option, or its superset -debug, will restore the full debug output.

sipa commented at 3:24 PM on June 14, 2012: member

I don't mind having more granularity in choosing debug output, but if we're going that way, I think a -debug=all, -debug=none, -debug=net, ... is more consistent.
luke-jr commented at 7:22 PM on June 15, 2012: member

Agree with @sipa
Diapolo commented at 12:15 AM on June 16, 2012: none

It could also be implemented as debug-level, e.g. -debug=0 (disabled) -debug=1 (all), -debug=2 (all, but no net) ... etc.
jgarzik commented at 1:20 AM on June 16, 2012: contributor

-debug=NUMBER and -debug=TOKEN are not useful for masking individual trace behaviors. -debug=TOKEN,TOKEN,... is acceptable, but requires a mini-parser for the -debug string, rather than relying on -trace* for the same effect.
sipa commented at 1:05 PM on June 16, 2012: member

Even if it's easier implementation-wise to keep it as a separate option, I'd prefer -debugnet instead of -tracenet, just for consistency.
gavinandresen commented at 3:54 PM on June 22, 2012: contributor

ACK if s/tracenet/debugnet/

Introduce -debugnet option, thereby quieting some redundant debug messages

Prior to this change, each TX typically generated 3+ debug messages,

	askfor tx 8644cc97480ba1537214   0
	sending getdata: tx 8644cc97480ba1537214
	askfor tx 8644cc97480ba1537214   1339640761000000
	askfor tx 8644cc97480ba1537214   1339640881000000
	CTxMemPool::accept() : accepted 8644cc9748 (poolsz 6857)

After this change, there is only one message for each valid TX received

	CTxMemPool::accept() : accepted 22a73c5d8c (poolsz 42)

and two messages for each orphan tx received

	ERROR: FetchInputs() : 673dc195aa mempool Tx prev not found 1e439346fc
	stored orphan tx 673dc195aa (mapsz 19)

The -debugnet option, or its superset -debug, will restore the full debug
output.

d07eaba195

jgarzik commented at 5:13 PM on June 22, 2012: contributor

updated to -debugnet
jgarzik referenced this in commit d62a1947be on Jun 22, 2012
jgarzik merged this on Jun 22, 2012
jgarzik closed this on Jun 22, 2012
Diapolo commented at 11:46 PM on June 22, 2012: none

I'm missing -debugnet and a description what it does in std::string HelpMessage() in init.cpp.

Should be below that line: https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L258
coblee referenced this in commit 4d886d7397 on Jul 17, 2012
jgarzik deleted the branch on Aug 24, 2014
suprnurd referenced this in commit 8572d54a98 on Dec 5, 2017
lateminer referenced this in commit d63ceda7d2 on Jan 22, 2019
lateminer referenced this in commit 8d8050fa6d on May 6, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#1507 -debugnet missing in help message