bool parseBitcoinURI(QString uri, SendCoinsRecipient *out) case sensitivity and space trimming #1460

From guiutil.cpp

if(uri.startsWith("bitcoin://"))
{
    uri.replace(0, 10, "bitcoin:");
}

(where uri is a QString)

now, the test is quite wrong. First it is a case sensitive test, but scheme names in URI are case insensitive (so BITCOIN:// is the same as bitcoin://). It should be uri.startsWith("bitcoin://", Qt::CaseInsensitive).

Second (but this I haven't tested), if QUrl works as other url parsers it trims the string before parsing it, so "\n\r\t bitcoin://something" is the same as "bitcoin://something", so a

uri.trimmed();

before the if wouldn't probably be bad (but note that uri.trimmed()).

Well it's not wrong, it handles the most common case of "broken" bitcoin URLs and does one final try to fix it (See https://en.bitcoin.it/wiki/BIP_0021 , bitcoin:// is wrong syntax). Sure, it could be extended, but it was never intended to be watertight.

But if you submit this as a pull request I'll merge it.

Tried this with Firefox, which converts an uppercase HTTP into a lowercase http while typing.