hebasto
commented at 2:52 PM on October 30, 2018:
member
Ref #13280
This PR removes the "Pay only the required fee..." checkbox from the custom transaction fee section in the "Send" tab. Instead, a minimum value will be enforced on the custom fee input box.
This adds functions for specifing a min/max value for a
BitcoinAmountField. These options only affect user input, so it's still
possible to use setValue to set values outside of the min/max range. The
existing value will not be changed when calling these functions even if
it's out of range. The min/max range will be reinforced when the field
loses focus.
This also adds `SetAllowEmpty` function which specifies if the field is
allowed to be left empty by the user. If set to false the field will be
set to the minimum allowed value if it's empty when focus is lost.
8711cc0c78
qt: Remove "Pay only required fee" checkbox
The custom fee input box now has a minimum value equal to the minimum
required fee. Before a value below the minimum fee could be entered
which was confusing since the minimum fee would still be paid even
though a lower amount was entered.
a16f44c040
fanquake added the label GUI on Oct 30, 2018
fanquake requested review from jonasschnelli on Nov 2, 2018
Sjors
commented at 5:40 PM on November 2, 2018:
member
tACKa16f44c on macOS 10.14.1
It doesn't make sense to cap the max fee rate at 21 000 000 BTC per kilobyte, but there's no harm either.
jonasschnelli
commented at 2:03 PM on November 4, 2018:
contributor
Concept ACK
meshcollider deleted a comment on Nov 4, 2018
MarcoFalke
commented at 10:35 PM on November 6, 2018:
member
utACKa16f44c040642432e234ad7317b00fe829c2d9e7
jonasschnelli approved
jonasschnelli
commented at 2:14 AM on November 7, 2018:
contributor
utACKa16f44c040642432e234ad7317b00fe829c2d9e7
laanwj
commented at 6:27 PM on November 10, 2018:
member
Concept ACK
jonasschnelli
commented at 8:43 AM on November 13, 2018:
contributor
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-04-14 00:15 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me