qt: Remove the "Pay only required fee..." checkbox #14608

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:20181030-remove-payonlyrequiredfee changing 5 files +75 −81
  1. hebasto commented at 2:52 PM on October 30, 2018: member

    Ref #13280 This PR removes the "Pay only the required fee..." checkbox from the custom transaction fee section in the "Send" tab. Instead, a minimum value will be enforced on the custom fee input box.

    All comments from #13280 are addressed.

    Before: screenshot from 2018-10-30 16-42-18

    After: screenshot from 2018-10-30 16-40-37

    cc: @promag @MarcoFalke @Sjors

  2. qt: Improve BitcoinAmountField class
    This adds functions for specifing a min/max value for a
    BitcoinAmountField. These options only affect user input, so it's still
    possible to use setValue to set values outside of the min/max range. The
    existing value will not be changed when calling these functions even if
    it's out of range. The min/max range will be reinforced when the field
    loses focus.
    This also adds `SetAllowEmpty` function which specifies if the field is
    allowed to be left empty by the user. If set to false the field will be
    set to the minimum allowed value if it's empty when focus is lost.
    8711cc0c78
  3. qt: Remove "Pay only required fee" checkbox
    The custom fee input box now has a minimum value equal to the minimum
    required fee. Before a value below the minimum fee could be entered
    which was confusing since the minimum fee would still be paid even
    though a lower amount was entered.
    a16f44c040
  4. fanquake added the label GUI on Oct 30, 2018
  5. fanquake requested review from jonasschnelli on Nov 2, 2018
  6. Sjors commented at 5:40 PM on November 2, 2018: member

    tACK a16f44c on macOS 10.14.1

    It doesn't make sense to cap the max fee rate at 21 000 000 BTC per kilobyte, but there's no harm either.

  7. jonasschnelli commented at 2:03 PM on November 4, 2018: contributor

    Concept ACK

  8. meshcollider deleted a comment on Nov 4, 2018
  9. MarcoFalke commented at 10:35 PM on November 6, 2018: member

    utACK a16f44c040642432e234ad7317b00fe829c2d9e7

  10. jonasschnelli approved
  11. jonasschnelli commented at 2:14 AM on November 7, 2018: contributor

    utACK a16f44c040642432e234ad7317b00fe829c2d9e7

  12. laanwj commented at 6:27 PM on November 10, 2018: member

    Concept ACK

  13. jonasschnelli commented at 8:43 AM on November 13, 2018: contributor

    Tested ACK a16f44c040642432e234ad7317b00fe829c2d9e7

  14. jonasschnelli merged this on Nov 13, 2018
  15. jonasschnelli closed this on Nov 13, 2018

  16. jonasschnelli referenced this in commit 083f535470 on Nov 13, 2018
  17. hebasto deleted the branch on Nov 13, 2018
  18. jasonbcox referenced this in commit 3e543f79b6 on Oct 29, 2020
  19. deadalnix referenced this in commit 0c86604333 on Oct 29, 2020
  20. christiancfifi referenced this in commit b63de04c75 on Aug 27, 2021
  21. christiancfifi referenced this in commit 8816d1aacc on Aug 27, 2021
  22. christiancfifi referenced this in commit f084b84d41 on Aug 27, 2021
  23. christiancfifi referenced this in commit 786dbd0c91 on Aug 28, 2021
  24. christiancfifi referenced this in commit 8ca36a34a8 on Aug 29, 2021
  25. christiancfifi referenced this in commit 4ae3653004 on Aug 29, 2021
  26. christiancfifi referenced this in commit 1457eda124 on Aug 29, 2021
  27. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 00:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me