Docs: correction to test readme compile instructions #14610

pull JBaczuk wants to merge 1 commits into bitcoin:master from JBaczuk:fix_test_readme_compile_instructions changing 1 files +2 −2
  1. JBaczuk commented at 5:00 PM on October 30, 2018: contributor

    I'm pretty sure this wording is just switched, but correct me if I'm wrong. If you have only changed a test file, you can just build the files in the test folder, no need to build the entire source.

  2. correction to test readme compile instructions 7636409892
  3. MarcoFalke commented at 5:56 PM on October 30, 2018: member

    Our compile tooling will notice that only test files have been modified and thus make will only compile the test files if they have been modified, so the wording as in master sounds correct to me.

  4. fanquake added the label Docs on Oct 30, 2018
  5. JBaczuk commented at 6:01 PM on November 1, 2018: contributor

    I'm just confused because it says, "If you modify a non-test file, use make -C src/test to recompile only what's needed to run the bitcoind tests."

    Wouldn't that only compile test files?

  6. sipa commented at 6:15 PM on November 1, 2018: member

    @JBaczuk And all core files needed to run those tests. Make reasons about dependencies.

    But it won't bother building the bitcoind binary, which isn't needed for the unit tests.

  7. JBaczuk commented at 6:41 PM on November 1, 2018: contributor

    @sipa Ah, ok, sounds like I'm mistaken, then, thanks.

  8. JBaczuk closed this on Nov 1, 2018

  9. MarcoFalke locked this on Sep 8, 2021
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 09:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me