The tests are no longer run on travis, but in a docker, developer machines or a windows vm.
The code was essentially dead for months now. Fix that by explicitly passing in --ci to the test runner on our docker and appveyor windows vm.
test_runner: Remove travis specific code #14630
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1811-testNoTravis changing 3 files +26 −18-
MarcoFalke commented at 2:59 PM on November 1, 2018: member
- laanwj added the label Tests on Nov 1, 2018
-
laanwj commented at 3:39 PM on November 1, 2018: member
makes sense — concept ACK
- MarcoFalke force-pushed on Nov 1, 2018
-
DrahtBot commented at 4:53 PM on November 1, 2018: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
- MarcoFalke force-pushed on Nov 1, 2018
-
jnewbery commented at 6:55 PM on November 1, 2018: member
Concept ACK.
Why so many style-only changes in the same commit?
-
MarcoFalke commented at 9:01 PM on November 1, 2018: member
Passing the value through touches a lot of function signatures and I run a python formatter on all changes I make before submitting a pull request. In the hope that no one can complain about my code style...
$ which yfd alias yfd='PATH=/home/marco/workspace/yapf-diff/virt_env_3_yapf/bin python3 /home/marco/workspace/yapf-diff/yapf-diff.py -p1 -i' -
jnewbery commented at 9:51 PM on November 1, 2018: member
A lot of it seems like your personal preference for style, and it inflates the diff substantially. For example, I don't think there's project guidelines about whether continuation lines of long function calls should be aligned to the opening parens or to some other indentation (both are fine under PEP8 https://www.python.org/dev/peps/pep-0008/#indentation).
This seems like a +-5 line diff without the style changes. At the least, can you split the style changes into a separate commit so it's obvious what reviewers are supposed to be paying attention to?
-
test_runner: Remove travis specific code fa43626611
- MarcoFalke force-pushed on Nov 1, 2018
-
MarcoFalke commented at 10:15 PM on November 1, 2018: member
Removed the style change that affected lines that were in proximity to actually changed lines.
- ken2812221 approved
-
ken2812221 commented at 4:19 AM on November 2, 2018: contributor
utACK fa43626611f4a76cbc361ea89e4989f80d2fa7d7
-
jnewbery commented at 5:51 PM on November 2, 2018: member
utACK fa43626611f4a76cbc361ea89e4989f80d2fa7d7
- MarcoFalke referenced this in commit 750415701c on Nov 2, 2018
- MarcoFalke merged this on Nov 2, 2018
- MarcoFalke closed this on Nov 2, 2018
- MarcoFalke deleted the branch on Nov 2, 2018
- codablock referenced this in commit 1e59b6af26 on Jan 7, 2020
- codablock referenced this in commit 743bd6c39e on Jan 7, 2020
- codablock referenced this in commit 26a6fef3b8 on Jan 7, 2020
- codablock referenced this in commit ef59dce92e on Jan 7, 2020
- ckti referenced this in commit 74e14d46e0 on Mar 28, 2021
- gades referenced this in commit c6bf277999 on Jun 30, 2021
- Munkybooty referenced this in commit bed81d1ecf on Jul 22, 2021
- Munkybooty referenced this in commit f82bbaa38e on Jul 22, 2021
- Munkybooty referenced this in commit b7de7e0718 on Jul 22, 2021
- Munkybooty referenced this in commit 1f4a49dd7e on Jul 23, 2021
- Munkybooty referenced this in commit d0e3e5916b on Jul 23, 2021
- Munkybooty referenced this in commit 6aa1958390 on Jul 23, 2021
- Munkybooty referenced this in commit 94a93cf5d7 on Jul 26, 2021
- Munkybooty referenced this in commit ad2a812144 on Jul 27, 2021
- Munkybooty referenced this in commit 6d4984b0a7 on Jul 28, 2021
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels