example_test.py: fixup coinbase height argument, derive number clearly #14664

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:example_cleanup changing 1 files +2 −2

instagibbs commented at 6:19 PM on November 5, 2018: member

No description provided.
example_test.py: fixup coinbase height argument, derive number clearly 6c5355e43d
MarcoFalke commented at 6:34 PM on November 5, 2018: member

utACK 6c5355e43d7c68c9ba71bc3170b15a6cf96bb9b4
promag commented at 6:45 PM on November 5, 2018: member

utACK 6c5355e.
MarcoFalke added the label Tests on Nov 5, 2018
MarcoFalke added the label Refactoring on Nov 5, 2018
in test/functional/example_test.py:167 in 6c5355e43d
```
 163 | @@ -164,13 +164,13 @@ def run_test(self):
 164 |          self.tip = int(self.nodes[0].getbestblockhash(), 16)
 165 |          self.block_time = self.nodes[0].getblock(self.nodes[0].getbestblockhash())['time'] + 1
 166 |  
 167 | -        height = 1
 168 | +        height = self.nodes[0].getblockcount()
```
MarcoFalke commented at 6:54 PM on November 5, 2018:

Actually the + 1 should be suffixed here (similar to block_time above?)

And then remove the change further down?

height = self.nodes[0].getblockcount() + 1
instagibbs commented at 6:58 PM on November 5, 2018:

2+10=12, and we're waiting for block 11, I'd have to change that too.

MarcoFalke commented at 7:03 PM on November 5, 2018:

Ok, fine.
MarcoFalke assigned MarcoFalke on Nov 5, 2018
MarcoFalke merged this on Nov 5, 2018
MarcoFalke closed this on Nov 5, 2018
MarcoFalke referenced this in commit 9c3f6c5fad on Nov 5, 2018
jasonbcox referenced this in commit 438ec29b07 on Oct 21, 2020
PastaPastaPasta referenced this in commit 1aa7cbd052 on Jun 27, 2021
PastaPastaPasta referenced this in commit 84975a3588 on Jun 28, 2021
PastaPastaPasta referenced this in commit f24f228e7a on Jun 29, 2021
PastaPastaPasta referenced this in commit afc96d7c2b on Jul 1, 2021
PastaPastaPasta referenced this in commit 358ed23765 on Jul 1, 2021
PastaPastaPasta referenced this in commit a0dd421a77 on Jul 1, 2021
PastaPastaPasta referenced this in commit ca000ff281 on Jul 3, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels